Skip to content

Commit 83c545b

Browse files
authored
fix: AVM-RES: Update preferredRoutingGateway and virtualRouterAsn (#6266)
- Changed preferredRoutingGateway from 'None' to 'ExpressRoute' - Updated virtualRouterAsn from 100 to 65515 - Adjusted test cases to reflect the new parameter values ## Description Fixes #6264 ## Pipeline Reference <!-- Insert your Pipeline Status Badge below --> | Pipeline | | -------- | [![avm.res.network.virtual-hub](https://github.com/arnoldna/bicep-registry-modules/actions/workflows/avm.res.network.virtual-hub.yml/badge.svg?branch=avm%2Fres%2Fnetwork%2Fvirtual-hub)](https://github.com/arnoldna/bicep-registry-modules/actions/workflows/avm.res.network.virtual-hub.yml) ## Type of Change <!-- Use the checkboxes [x] on the options that are relevant. --> - Azure Verified Module updates: - [X] Bugfix containing backwards-compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in `version.json`: - [ ] Feature update backwards compatible feature updates, and I have bumped the MINOR version in `version.json`. - [ ] Breaking changes and I have bumped the MAJOR version in `version.json`. - [X] Update to documentation - [ ] Update to CI Environment or utilities (Non-module affecting changes) ## Checklist - [X] I'm sure there are no other open Pull Requests for the same update/change - [X] I have run `Set-AVMModule` locally to generate the supporting module files. - [X] My corresponding pipelines / checks run clean and green without any errors or warnings - [ ] I have updated the module's CHANGELOG.md file with an entry for the next version <!-- Please keep up to date with the contribution guide at https://aka.ms/avm/contribute/bicep -->
1 parent bd73d2e commit 83c545b

File tree

2 files changed

+10
-12
lines changed

2 files changed

+10
-12
lines changed

avm/res/network/virtual-hub/README.md

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -164,15 +164,15 @@ module virtualHub 'br/public:avm/res/network/virtual-hub:<version>' = {
164164
kind: 'CanNotDelete'
165165
name: 'myCustomLockName'
166166
}
167-
preferredRoutingGateway: 'None'
167+
preferredRoutingGateway: 'ExpressRoute'
168168
routingIntent: {}
169169
sku: 'Standard'
170170
tags: {
171171
Environment: 'Non-Prod'
172172
'hidden-title': 'This is visible in the resource name'
173173
Role: 'DeploymentValidation'
174174
}
175-
virtualRouterAsn: 100
175+
virtualRouterAsn: 65515
176176
virtualRouterAutoScaleConfiguration: {
177177
minCount: 2
178178
}
@@ -259,7 +259,7 @@ module virtualHub 'br/public:avm/res/network/virtual-hub:<version>' = {
259259
}
260260
},
261261
"preferredRoutingGateway": {
262-
"value": "None"
262+
"value": "ExpressRoute"
263263
},
264264
"routingIntent": {
265265
"value": {}
@@ -275,7 +275,7 @@ module virtualHub 'br/public:avm/res/network/virtual-hub:<version>' = {
275275
}
276276
},
277277
"virtualRouterAsn": {
278-
"value": 100
278+
"value": 65515
279279
},
280280
"virtualRouterAutoScaleConfiguration": {
281281
"value": {
@@ -346,15 +346,15 @@ param lock = {
346346
kind: 'CanNotDelete'
347347
name: 'myCustomLockName'
348348
}
349-
param preferredRoutingGateway = 'None'
349+
param preferredRoutingGateway = 'ExpressRoute'
350350
param routingIntent = {}
351351
param sku = 'Standard'
352352
param tags = {
353353
Environment: 'Non-Prod'
354354
'hidden-title': 'This is visible in the resource name'
355355
Role: 'DeploymentValidation'
356356
}
357-
param virtualRouterAsn = 100
357+
param virtualRouterAsn = 65515
358358
param virtualRouterAutoScaleConfiguration = {
359359
minCount: 2
360360
}

avm/res/network/virtual-hub/tests/e2e/max/main.test.bicep

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -98,16 +98,14 @@ module testDeployment '../../../main.bicep' = [
9898
}
9999
}
100100
]
101-
sku:'Standard'
101+
sku: 'Standard'
102102
virtualRouterAutoScaleConfiguration: {
103103
minCount: 2
104104
}
105-
preferredRoutingGateway: 'None'
105+
preferredRoutingGateway: 'ExpressRoute'
106106
hubRoutingPreference: 'ASPath'
107-
virtualRouterAsn: 100
108-
routingIntent: {
109-
110-
}
107+
virtualRouterAsn: 65515
108+
routingIntent: {}
111109
tags: {
112110
'hidden-title': 'This is visible in the resource name'
113111
Environment: 'Non-Prod'

0 commit comments

Comments
 (0)