Skip to content

Commit 792152f

Browse files
Copilotv-jiaodi
andauthored
[azure-http-specs] Add !javascript scope to @OverRide decorator for GroupParameters.group (#3389)
- [x] Understand the current state and verify the file structure - [x] Update line 29 in client.tsp to add "!javascript" scope parameter - [x] Format code with Prettier - [x] Add changeset using chronus - [x] Test the changes to ensure they work correctly - [x] Verify no other related changes are needed ## Summary Updated the `@override` decorator for `GroupParameters.group` operation in `/packages/azure-http-specs/specs/azure/client-generator-core/override/client.tsp` to add the `"!javascript"` scope parameter. This excludes JavaScript emitters from this override customization. ### Changes Made: 1. Changed line 29 to add `"!javascript"` scope parameter 2. Formatted the code with Prettier to follow multiline style 3. Added a changeset for the azure-http-specs package ### Final Code: ```typespec @@OverRide(_Specs_.Azure.ClientGenerator.Core.Override.GroupParameters.group, groupCustomized, "!javascript" ); ``` ### Verification: - ✅ Full build successful - ✅ All typespec-client-generator-core tests pass (992 tests) - ✅ All scenario validations pass (58 full scenarios, 40 scenarios) - ✅ Code formatted with Prettier - ✅ Changeset added using chronus <!-- START COPILOT CODING AGENT SUFFIX --> <details> <summary>Original prompt</summary> > > ---- > > *This section details on the original issue you should resolve* > > <issue_title>[JS] @OverRide group is not supported yet.</issue_title> > <issue_description>Update https://github.com/Azure/typespec-azure/blob/main/packages/azure-http-specs/specs/azure/client-generator-core/override/client.tsp#L29 > to `@@OverRide(_Specs_.Azure.ClientGenerator.Core.Override.GroupParameters.group, groupCustomized, "!javascript");`</issue_description> > > ## Comments on the Issue (you are @copilot in this section) > > <comments> > </comments> > </details> Fixes #3388 <!-- START COPILOT CODING AGENT TIPS --> --- 💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click [here](https://survey3.medallia.com/?EAHeSx-AP01bZqG0Ld9QLQ) to start the survey. --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: v-jiaodi <[email protected]>
1 parent e10e4dc commit 792152f

File tree

2 files changed

+11
-1
lines changed

2 files changed

+11
-1
lines changed
Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
---
2+
changeKind: internal
3+
packages:
4+
- "@azure-tools/azure-http-specs"
5+
---
6+
7+
Add !javascript scope to @override decorator for GroupParameters.group

packages/azure-http-specs/specs/azure/client-generator-core/override/client.tsp

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,10 @@ model GroupParametersOptions {
2626

2727
op groupCustomized(options: GroupParametersOptions): void;
2828

29-
@@override(_Specs_.Azure.ClientGenerator.Core.Override.GroupParameters.group, groupCustomized);
29+
@@override(_Specs_.Azure.ClientGenerator.Core.Override.GroupParameters.group,
30+
groupCustomized,
31+
"!javascript"
32+
);
3033

3134
op requireOptionalCustomized(@path param1: string, @path param2: string): void;
3235

0 commit comments

Comments
 (0)