-
Notifications
You must be signed in to change notification settings - Fork 1
commit all staged changes #29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Snyk has created this PR to upgrade @0xsequence/api from 2.1.0 to 2.3.2. See this package in npm: @0xsequence/api See this project in Snyk: https://app.snyk.io/org/boomchainlabs/project/42c4597c-9670-46ff-8dde-749ab492d173?utm_source=github&utm_medium=referral&page=upgrade-pr
Snyk has created this PR to upgrade @0xsequence/kit-checkout from 4.4.4 to 4.6.5. See this package in npm: @0xsequence/kit-checkout See this project in Snyk: https://app.snyk.io/org/boomchainlabs/project/42c4597c-9670-46ff-8dde-749ab492d173?utm_source=github&utm_medium=referral&page=upgrade-pr
Snyk has created this PR to upgrade @0xsequence/api from 2.3.2 to 2.3.7. See this package in npm: @0xsequence/api See this project in Snyk: https://app.snyk.io/org/boomchainlabs/project/42c4597c-9670-46ff-8dde-749ab492d173?utm_source=github&utm_medium=referral&page=upgrade-pr
Snyk has created this PR to upgrade ethers from 6.13.4 to 6.13.6. See this package in npm: ethers See this project in Snyk: https://app.snyk.io/org/boomchainlabs/project/42c4597c-9670-46ff-8dde-749ab492d173?utm_source=github&utm_medium=referral&page=upgrade-pr
Snyk has created this PR to upgrade @0xsequence/api from 2.3.7 to 2.3.8. See this package in npm: @0xsequence/api See this project in Snyk: https://app.snyk.io/org/boomchainlabs/project/42c4597c-9670-46ff-8dde-749ab492d173?utm_source=github&utm_medium=referral&page=upgrade-pr
Snyk has created this PR to upgrade @0xsequence/api from 2.3.8 to 2.3.9. See this package in npm: @0xsequence/api See this project in Snyk: https://app.snyk.io/org/boomchainlabs/project/42c4597c-9670-46ff-8dde-749ab492d173?utm_source=github&utm_medium=referral&page=upgrade-pr
Snyk has created this PR to upgrade ethers from 6.13.6 to 6.13.7. See this package in npm: ethers See this project in Snyk: https://app.snyk.io/org/boomchainlabs/project/42c4597c-9670-46ff-8dde-749ab492d173?utm_source=github&utm_medium=referral&page=upgrade-pr
Snyk has created this PR to upgrade @0xsequence/api from 2.3.9 to 2.3.11. See this package in npm: @0xsequence/api See this project in Snyk: https://app.snyk.io/org/boomchainlabs/project/42c4597c-9670-46ff-8dde-749ab492d173?utm_source=github&utm_medium=referral&page=upgrade-pr
…a0cb99a2b36b1e
Snyk has created this PR to upgrade @0xsequence/api from 2.3.11 to 2.3.12. See this package in npm: @0xsequence/api See this project in Snyk: https://app.snyk.io/org/boomchainlabs/project/42c4597c-9670-46ff-8dde-749ab492d173?utm_source=github&utm_medium=referral&page=upgrade-pr
…274ec5d989ea6a
…d1baacebbe7e18
Snyk has created this PR to upgrade @0xsequence/api from 2.3.12 to 2.3.16. See this package in npm: @0xsequence/api See this project in Snyk: https://app.snyk.io/org/boomchainlabs/project/42c4597c-9670-46ff-8dde-749ab492d173?utm_source=github&utm_medium=referral&page=upgrade-pr
Snyk has created this PR to upgrade ethers from 6.13.7 to 6.14.1. See this package in npm: ethers See this project in Snyk: https://app.snyk.io/org/boomchainlabs/project/42c4597c-9670-46ff-8dde-749ab492d173?utm_source=github&utm_medium=referral&page=upgrade-pr
…47cb685cbde5b5
…d323e47043a8fa
Snyk has created this PR to upgrade ethers from 6.14.1 to 6.14.3. See this package in npm: ethers See this project in Snyk: https://app.snyk.io/org/boomchainlabs/project/42c4597c-9670-46ff-8dde-749ab492d173?utm_source=github&utm_medium=referral&page=upgrade-pr
Snyk has created this PR to upgrade @0xsequence/api from 2.3.16 to 2.3.17. See this package in npm: @0xsequence/api See this project in Snyk: https://app.snyk.io/org/boomchainlabs/project/42c4597c-9670-46ff-8dde-749ab492d173?utm_source=github&utm_medium=referral&page=upgrade-pr
…d7a53c2321580c
…68eea8173a9060
Signed-off-by: BoomchainLabs <[email protected]>
Snyk has created this PR to upgrade @0xsequence/api from 2.3.17 to 2.3.20. See this package in npm: @0xsequence/api See this project in Snyk: https://app.snyk.io/org/boomchainlabs/project/42c4597c-9670-46ff-8dde-749ab492d173?utm_source=github&utm_medium=referral&page=upgrade-pr
Snyk has created this PR to upgrade ethers from 6.14.3 to 6.14.4. See this package in npm: ethers See this project in Snyk: https://app.snyk.io/org/boomchainlabs/project/42c4597c-9670-46ff-8dde-749ab492d173?utm_source=github&utm_medium=referral&page=upgrade-pr
…b69b6b2247ee18
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-ELLIPTIC-8187303
…d4d800b18ce560
Snyk has created this PR to upgrade viem from 2.21.51 to 2.37.3. See this package in npm: viem See this project in Snyk: https://app.snyk.io/org/boomchainlabs/project/42c4597c-9670-46ff-8dde-749ab492d173?utm_source=github&utm_medium=referral&page=upgrade-pr
Snyk has created this PR to upgrade @tanstack/react-query from 5.61.4 to 5.87.1. See this package in npm: @tanstack/react-query See this project in Snyk: https://app.snyk.io/org/boomchainlabs/project/42c4597c-9670-46ff-8dde-749ab492d173?utm_source=github&utm_medium=referral&page=upgrade-pr
…680ed42f304ec0
…44910aa466b2cc
WalkthroughAdds a GitHub Actions workflow to publish packages to PyPI on version tags and updates multiple JavaScript dependencies in Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor Dev as Developer
participant GH as GitHub
participant Runner as GitHub Runner (ubuntu-latest)
participant PyPI as PyPI Registry
Dev->>GH: Push tag vX.Y.Z
GH-->>Runner: Trigger "Publish to PyPI"
rect rgba(200,220,255,0.25)
note right of Runner: Setup
Runner->>Runner: actions/checkout@v4
Runner->>Runner: actions/setup-python@v5 (3.11)
Runner->>Runner: pip install pip, build, twine
end
rect rgba(200,255,200,0.25)
note right of Runner: Build
Runner->>Runner: python -m build
end
rect rgba(255,240,200,0.25)
note right of Runner: Publish
Runner->>PyPI: twine upload dist/* (auth: __token__/PYPI_API_TOKEN)
alt Success
PyPI-->>Runner: 200 OK
else Failure
PyPI-->>Runner: error
end
end
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Note Unit test generation is an Early Access feature. Expect some limitations and changes as we gather feedback and continue to improve it. Generating unit tests... This may take up to 20 minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
| - name: Publish to PyPI | ||
| env: | ||
| TWINE_USERNAME: __token__ | ||
| TWINE_PASSWORD: ${{ secrets.PYPI_API_TOKEN }} | ||
| run: twine upload dist/* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add --skip-existing so publishes are re-runnable.
If the workflow retries after a successful upload (for example, PyPI accepted the artifacts but a later step failed, or someone re-runs the job), PyPI will reject the duplicate files and the job will now fail permanently. Including --skip-existing keeps the publish step idempotent while still surfacing genuine upload issues.
- run: twine upload dist/*
+ run: twine upload --skip-existing dist/*📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| - name: Publish to PyPI | |
| env: | |
| TWINE_USERNAME: __token__ | |
| TWINE_PASSWORD: ${{ secrets.PYPI_API_TOKEN }} | |
| run: twine upload dist/* | |
| - name: Publish to PyPI | |
| env: | |
| TWINE_USERNAME: __token__ | |
| TWINE_PASSWORD: ${{ secrets.PYPI_API_TOKEN }} | |
| run: twine upload --skip-existing dist/* |
🤖 Prompt for AI Agents
In .github/workflows/pypi-publish.yml around lines 29-33 the twine upload step
is not idempotent and will fail on retries if PyPI already has the files; update
the twine upload invocation to include the --skip-existing flag so duplicate
distributions are ignored and the publish step becomes re-runnable (leave the
TWINE_USERNAME and TWINE_PASSWORD env as-is).
| "@0xsequence/api": "2.3.20", | ||
| "@0xsequence/design-system": "^1.8.0", | ||
| "@0xsequence/indexer": "^2.1.0", | ||
| "@0xsequence/kit": "4.4.4", | ||
| "@0xsequence/kit-checkout": "4.4.4", | ||
| "@0xsequence/kit-checkout": "4.6.5", | ||
| "@0xsequence/metadata": "2.1.0", | ||
| "@0xsequence/network": "^2.1.0", | ||
| "@tanstack/react-query": "^5.61.4", | ||
| "@tanstack/react-query": "^5.87.1", | ||
| "dotenv": "^16.4.5", | ||
| "ethers": "6.13.4", | ||
| "ethers": "6.14.4", | ||
| "react": "^18.3.1", | ||
| "react-dom": "^18.3.1", | ||
| "react-toastify": "^10.0.6", | ||
| "viem": "^2.21.51", | ||
| "wagmi": "^2.13.0" | ||
| "viem": "^2.37.3", | ||
| "wagmi": "^2.14.16" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commit the updated pnpm lockfile alongside these bumps.
These version bumps change the desired resolutions, but pnpm-lock.yaml wasn’t updated. With pnpm 9 (per the packageManager field), a pnpm install --frozen-lockfile run in CI will throw ERR_PNPM_LOCKFILE_BREAKING_CHANGE, and even a local install will rewrite the lock file. Please regenerate the lock (pnpm install or pnpm update <pkg>) and commit it so the intended versions land in the pipeline.
🤖 Prompt for AI Agents
In package.json around lines 19 to 33, the dependency version bumps were made
but the pnpm lockfile wasn’t updated; run pnpm (v9) to regenerate the lock and
commit it. Execute pnpm install (or pnpm update <pkg> for selective bumps)
locally to update pnpm-lock.yaml (CI will error with
ERR_PNPM_LOCKFILE_BREAKING_CHANGE if it’s missing), verify changes, and
add/commit the updated pnpm-lock.yaml alongside this package.json change.
|
Here are the copyable unit test edits: Copyable Editstests/pypi-publish-workflow.test.jsThis is a new file. biome.jsonThis is a new file. coderabbit.markdownlint-cli2.jsoncThis is a new file. jest.config.jsThis is a new file. package.json@@ -12,6 +12,9 @@
"lint": "eslint .",
"lint:fix": "eslint . --fix",
"preview": "vite preview",
+ ,"test": "jest",
+ ,"test:watch": "jest --watch",
+ ,"test:coverage": "jest --coverage",
"postinstall": "(cp -n .env.example .env) || echo already exists"
},
"dependencies": {
@@ -49,6 +52,7 @@
"typescript-eslint": "^8.16.0",
"vite": "^5.4.17",
"wrangler": "^3.91.0"
+ ,"jest": "^29.7.0"
},
"packageManager": "[email protected]+sha512.140036830124618d624a2187b50d04289d5a087f326c9edfc0ccd733d76c4f52c3a313d4fc148794a2a9d81553016004e6742e8cf850670268a7387fc220c903"
}tests/package.json.schema.test.jsThis is a new file. tests/package.json.scripts.test.jsThis is a new file. tests/package.json.security.test.jsThis is a new file. tests/package.json.test.jsThis is a new file. tests/README.mdThis is a new file. |
Snyk has created this PR to upgrade viem from 2.21.51 to 2.37.5. See this package in npm: viem See this project in Snyk: https://app.snyk.io/org/boomchainlabs/project/42c4597c-9670-46ff-8dde-749ab492d173?utm_source=github&utm_medium=referral&page=upgrade-pr
Snyk has created this PR to upgrade @tanstack/react-query from 5.61.4 to 5.87.4. See this package in npm: @tanstack/react-query See this project in Snyk: https://app.snyk.io/org/boomchainlabs/project/42c4597c-9670-46ff-8dde-749ab492d173?utm_source=github&utm_medium=referral&page=upgrade-pr
…a635bd8df1aed1
…aa6946afbd7cdc
Snyk has created this PR to upgrade viem from 2.21.51 to 2.37.6. See this package in npm: viem See this project in Snyk: https://app.snyk.io/org/boomchainlabs/project/42c4597c-9670-46ff-8dde-749ab492d173?utm_source=github&utm_medium=referral&page=upgrade-pr
Snyk has created this PR to upgrade @tanstack/react-query from 5.61.4 to 5.89.0. See this package in npm: @tanstack/react-query See this project in Snyk: https://app.snyk.io/org/boomchainlabs/project/42c4597c-9670-46ff-8dde-749ab492d173?utm_source=github&utm_medium=referral&page=upgrade-pr
…6f16ccab9df032
…b60d55fcd18696
This change is
Summary by CodeRabbit