test: WilliamsR StreamHub late arrival tests

[Copilot]

The WilliamsR StreamHub test had basic rollback validation but didn't follow the canonical pattern established for other indicators (EMA, ADX). Missing: warmup prefill, late arrival (Insert), duplicate handling, and proper base class constant usage.

Changes

• Enhanced QuoteObserver_WithWarmupLateArrivalAndRemoval_MatchesSeriesExactly()
  • Prefill 20 quotes before observer initialization (warmup coverage)
  • Skip quote at index 80, stream remaining quotes
  • Resend duplicates at indices 101-104
  • Insert skipped quote and verify against original series
  • Remove quote using base class removeAtIndex constant (495), not hardcoded value
  • Compare against RevisedQuotes from base class
  • Add strict ordering verification with BeEquivalentTo(..., o => o.WithStrictOrdering())
  • Add proper cleanup (Unsubscribe(), EndTransmission())

Pattern

Now matches canonical EMA/ADX StreamHub test structure:

// Prefill warmup
quoteHub.Add(Quotes.Take(20));
WilliamsRHub observer = quoteHub.ToWilliamsRHub(lookbackPeriods);

// Stream with skip and duplicates
for (int i = 20; i < length; i++) {
    if (i == 80) { continue; }
    quoteHub.Add(Quotes[i]);
    if (i is > 100 and < 105) { quoteHub.Add(Quotes[i]); }
}

// Validate Insert/Remove operations
quoteHub.Insert(Quotes[80]);
actuals.Should().BeEquivalentTo(expectedOriginal, o => o.WithStrictOrdering());

quoteHub.Remove(Quotes[removeAtIndex]);
actuals.Should().BeEquivalentTo(RevisedQuotes.ToWilliamsR(lookbackPeriods), o => o.WithStrictOrdering());

Addresses follow-on task T177 from #1723.

Original prompt

---

This section details on the original issue you should resolve

<issue_title>add rollback validation tests for WilliamsR StreamHub</issue_title>
<issue_description>## Problem

The WilliamsR StreamHub indicator currently has basic rollback validation but doesn't follow the full comprehensive pattern established for other indicators. The test should be enhanced to match the canonical EMA/ADX pattern.

Required Test Cases

The WilliamsR QuoteObserver test should include (following the canonical EMA/ADX pattern):

1. Prefill warmup: Add 20-30 quotes before observer initialization
2. Streaming with skip: Stream remaining quotes, skip quote at index 80
3. Duplicate handling: Resend duplicates for indices 101-104
4. Late arrival (Insert): Insert the skipped quote and verify Series parity
5. Removal: Remove quote at removeAtIndex constant (495) from base class, not hardcoded value
6. Revised series parity: Use RevisedQuotes from base class for comparison
7. Strict ordering: Use BeEquivalentTo(series, o => o.WithStrictOrdering())
8. Cleanup: Call Unsubscribe() and EndTransmission()

Key Requirements

• Must use base class removeAtIndex constant (495) for consistency across tests
• Must use base class RevisedQuotes for revised series comparison
• Should follow exact pattern from tests/indicators/e-k/Ema/Ema.StreamHub.Tests.cs

Reference

• Project task: T177 (Comprehensive Rollback Validation)
• Task file: .specify/specs/001-develop-streaming-indicators/tasks.md
• Canonical pattern: tests/indicators/e-k/Ema/Ema.StreamHub.Tests.cs QuoteObserver method
• Current test: tests/indicators/s-z/WilliamsR/WilliamsR.StreamHub.Tests.cs
• Implementation: src/s-z/WilliamsR/WilliamsR.StreamHub.cs

Success Criteria

• All comprehensive rollback test cases pass
• Uses base class constants (removeAtIndex, RevisedQuotes) consistently
• Follows exact pattern from canonical EMA test
• No hardcoded indices or test data

This is a follow-on task from #1723 </issue_description>

Comments on the Issue (you are @copilot in this section)

Custom agent used: streamhub
Expert guidance for StreamHub indicator development - implementation patterns, provider selection, state management, and real-time processing

• Fixes add rollback validation tests for WilliamsR StreamHub #1725

---

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

[coderabbitai]

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

📝 Walkthrough

Walkthrough

The test file for WilliamsR StreamHub has been restructured to implement comprehensive rollback validation. The modifications establish a warmup phase using prefilled quotes, defer observer creation, then progressively add quotes with simulated streaming conditions including skipped indices and duplicate re-entries. A late-arrival quote is inserted, streaming results are validated against batch-computed expectations, followed by a deletion step with revised series comparison. The test concludes with cleanup operations.

Assessment against linked issues

Objective	Addressed	Explanation
Prefill warmup (add 20-30 quotes before observer initialization) and streaming with skip, duplicate handling, late arrival validation (#1725)	✅
Removal using base class removeAtIndex constant and revised series parity using base class RevisedQuotes (#1725)	❓	The summary references a "deletion step" and "revised expected series" but does not specify whether the removeAtIndex constant from the base class is used or if the value is hardcoded, and whether RevisedQuotes from the base class is referenced.
Strict ordering assertion using BeEquivalentTo(series, o => o.WithStrictOrdering()) and cleanup with Unsubscribe() and EndTransmission() (#1725)	❓	The summary confirms cleanup operations are present but does not specify the exact assertion syntax used for result comparison.

Possibly related PRs

• feat: WilliamsR streaming indicators #1466: Introduced the original StreamHub tests for WilliamsR that this PR directly modifies and enhances with comprehensive rollback validation patterns.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[DaveSkender]

@coderabbitai full review

[coderabbitai]

✅ Actions performed

Full review triggered.