.github: switch from actions/cache to actions/{download,upload}-artifact (#1584)

colemickens · web-flow · commit dfa52d08d4b0 · 2025-06-18T17:17:42.000Z
* .github: switch from actions/cache to actions/{download,upload}-artifact

* .github: switch from actions/cache... fixup download path

* .github: switch from actions/cache... more fixups

* .github: switch from actions/cache... more cache-&gt;artifact

* .github: switch from actions/cache... debug

* .github: switch from actions/cache... artifact has a wrapper dir

* .github: switch from actions/cache... GHA is really something
diff --git a/.github/workflows/build-aarch64-darwin.yml b/.github/workflows/build-aarch64-darwin.yml
@@ -2,17 +2,11 @@ name: Build aarch64 Darwin
 
 on:
   workflow_call:
-    inputs:
-      cache-key:
-        type: string
-        required: false
-        default: aarch64-darwin-artifacts-${{ github.sha }}
 
 jobs:
   build-aarch64-darwin:
     name: Build aarch64 Darwin (static)
     runs-on: namespace-profile-mac-m2-12c28g
-    concurrency: ${{ inputs.cache-key }}
     permissions:
       id-token: "write"
       contents: "read"
@@ -24,9 +18,9 @@ jobs:
       - name: Build the installer
         run: |
           nix build .#packages.aarch64-darwin.nix-installer-static -L
-          cp result/bin/nix-installer .
-      - name: Create GitHub cache from build artifacts
-        uses: actions/cache/save@v4
+          cp result/bin/nix-installer ./nix-installer-aarch64-darwin
+      - name: Create GitHub artifacts from build outputs
+        uses: actions/upload-artifact@v4
         with:
-          path: nix-installer
-          key: ${{ inputs.cache-key }}
+          path: nix-installer-aarch64-darwin
+          name: nix-installer-aarch64-darwin
diff --git a/.github/workflows/build-aarch64-linux.yml b/.github/workflows/build-aarch64-linux.yml
@@ -2,17 +2,11 @@ name: Build aarch64 Linux (static)
 
 on:
   workflow_call:
-    inputs:
-      cache-key:
-        type: string
-        required: false
-        default: aarch64-linux-artifacts-${{ github.sha }}
 
 jobs:
   build-aarch64-linux:
     name: Build aarch64 Linux (static)
     runs-on: UbuntuLatest32Cores128GArm
-    concurrency: ${{ inputs.cache-key }}
     permissions:
       id-token: "write"
       contents: "read"
@@ -24,9 +18,9 @@ jobs:
       - name: Build the installer
         run: |
           nix build .#packages.aarch64-linux.nix-installer-static -L
-          cp result/bin/nix-installer .
-      - name: Create GitHub cache from build artifacts
-        uses: actions/cache/save@v4
+          cp result/bin/nix-installer ./nix-installer-aarch64-linux
+      - name: Create GitHub artifacts from build outputs
+        uses: actions/upload-artifact@v4
         with:
-          path: nix-installer
-          key: ${{ inputs.cache-key }}
+          path: nix-installer-aarch64-linux
+          name: nix-installer-aarch64-linux
diff --git a/.github/workflows/build-x86_64-darwin.yml b/.github/workflows/build-x86_64-darwin.yml
@@ -2,17 +2,11 @@ name: Build x86_64 Darwin
 
 on:
   workflow_call:
-    inputs:
-      cache-key:
-        type: string
-        required: false
-        default: x86_64-darwin-artifacts-${{ github.sha }}
 
 jobs:
   build-x86_64-darwin:
     name: Build x86_64 Darwin (static)
     runs-on: namespace-profile-mac-m2-12c28g
-    concurrency: ${{ inputs.cache-key }}
     permissions:
       id-token: "write"
       contents: "read"
@@ -24,9 +18,9 @@ jobs:
       - name: Build the installer
         run: |
           nix build .#packages.x86_64-darwin.nix-installer-static -L
-          cp result/bin/nix-installer .
-      - name: Create GitHub cache from build artifacts
-        uses: actions/cache/save@v4
+          cp result/bin/nix-installer ./nix-installer-x86_64-darwin
+      - name: Create GitHub artifacts from build outputs
+        uses: actions/upload-artifact@v4
         with:
-          path: nix-installer
-          key: ${{ inputs.cache-key }}
+          path: nix-installer-x86_64-darwin
+          name: nix-installer-x86_64-darwin
diff --git a/.github/workflows/build-x86_64-linux.yml b/.github/workflows/build-x86_64-linux.yml
@@ -2,17 +2,11 @@ name: Build x86_64 Linux (static)
 
 on:
   workflow_call:
-    inputs:
-      cache-key:
-        type: string
-        required: false
-        default: x86_64-linux-artifacts-${{ github.sha }}
 
 jobs:
   build-x86_64-linux:
     name: Build x86_64 Linux (static)
     runs-on: UbuntuLatest32Cores128G
-    concurrency: ${{ inputs.cache-key }}
     permissions:
       id-token: "write"
       contents: "read"
@@ -24,9 +18,9 @@ jobs:
       - name: Build the installer
         run: |
           nix build .#packages.x86_64-linux.nix-installer-static -L
-          cp result/bin/nix-installer .
-      - name: Create GitHub cache from build artifacts
-        uses: actions/cache/save@v4
+          cp result/bin/nix-installer ./nix-installer-x86_64-linux
+      - name: Create GitHub artifacts from build outputs
+        uses: actions/upload-artifact@v4
         with:
-          path: nix-installer
-          key: ${{ inputs.cache-key }}
+          path: nix-installer-x86_64-linux
+          name: nix-installer-x86_64-linux
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -65,15 +65,14 @@ jobs:
     steps:
       - uses: actions/checkout@v4
       - name: Restore Github cache artifacts
-        uses: actions/cache/restore@v4
+        uses: actions/download-artifact@v4
         with:
-          path: nix-installer
-          key: x86_64-linux-artifacts-${{ github.sha }}
+          name: nix-installer-x86_64-linux
       - name: Move & set executable
         run: |
           mkdir install-root
           cp nix-installer.sh install-root/nix-installer.sh
-          mv ./nix-installer install-root/nix-installer-x86_64-linux
+          mv ./nix-installer-x86_64-linux install-root/
           chmod +x install-root/nix-installer-x86_64-linux install-root/nix-installer.sh
       - run: sudo apt install fish zsh
       - name: Initial install
@@ -183,15 +182,14 @@ jobs:
     steps:
       - uses: actions/checkout@v4
       - name: Restore Github cache artifacts
-        uses: actions/cache/restore@v4
+        uses: actions/download-artifact@v4
         with:
-          path: nix-installer
-          key: x86_64-linux-artifacts-${{ github.sha }}
+          name: nix-installer-x86_64-linux
       - name: Move & set executable
         run: |
           mkdir install-root
           cp nix-installer.sh install-root/nix-installer.sh
-          mv ./nix-installer install-root/nix-installer-x86_64-linux
+          mv ./nix-installer-x86_64-linux install-root/
           chmod +x install-root/nix-installer-x86_64-linux install-root/nix-installer.sh
       - run: sudo apt install fish zsh
       - name: Initial install
@@ -307,15 +305,14 @@ jobs:
     steps:
       - uses: actions/checkout@v4
       - name: Restore Github cache artifacts
-        uses: actions/cache/restore@v4
+        uses: actions/download-artifact@v4
         with:
-          path: nix-installer
-          key: x86_64-darwin-artifacts-${{ github.sha }}
+          name: nix-installer-x86_64-darwin
       - name: Move & set executable
         run: |
           mkdir install-root
           cp nix-installer.sh install-root/nix-installer.sh
-          mv ./nix-installer install-root/nix-installer-x86_64-darwin
+          mv ./nix-installer-x86_64-darwin install-root/
           chmod +x install-root/nix-installer-x86_64-darwin install-root/nix-installer.sh
       - run: brew install fish coreutils
       - name: Initial install
@@ -397,15 +394,14 @@ jobs:
     steps:
       - uses: actions/checkout@v4
       - name: Restore Github cache artifacts
-        uses: actions/cache/restore@v4
+        uses: actions/download-artifact@v4
         with:
-          path: nix-installer
-          key: aarch64-linux-artifacts-${{ github.sha }}
+          name: nix-installer-aarch64-linux
       - name: Move & set executable
         run: |
           mkdir install-root
           cp nix-installer.sh install-root/nix-installer.sh
-          mv ./nix-installer install-root/nix-installer-aarch64-linux
+          mv ./nix-installer-aarch64-linux install-root/
           chmod +x install-root/nix-installer-aarch64-linux install-root/nix-installer.sh
       - run: sudo apt install -y fish zsh
       - name: Initial install
@@ -515,15 +511,14 @@ jobs:
     steps:
       - uses: actions/checkout@v4
       - name: Restore Github cache artifacts
-        uses: actions/cache/restore@v4
+        uses: actions/download-artifact@v4
         with:
-          path: nix-installer
-          key: aarch64-darwin-artifacts-${{ github.sha }}
+          name: nix-installer-aarch64-darwin
       - name: Move & set executable
         run: |
           mkdir install-root
           cp nix-installer.sh install-root/nix-installer.sh
-          mv ./nix-installer install-root/nix-installer-aarch64-darwin
+          mv ./nix-installer-aarch64-darwin install-root/
           chmod +x install-root/nix-installer-aarch64-darwin install-root/nix-installer.sh
       - run: brew install fish coreutils
       - name: Initial install
@@ -611,15 +606,14 @@ jobs:
     steps:
       - uses: actions/checkout@v4
       - name: Restore Github cache artifacts
-        uses: actions/cache/restore@v4
+        uses: actions/download-artifact@v4
         with:
-          path: nix-installer
-          key: x86_64-linux-artifacts-${{ github.sha }}
+          name: nix-installer-x86_64-linux
       - name: Move & set executable
         run: |
           mkdir install-root
           cp nix-installer.sh install-root/nix-installer.sh
-          mv ./nix-installer install-root/nix-installer-x86_64-linux
+          mv ./nix-installer-x86_64-linux install-root/
           chmod +x install-root/nix-installer-x86_64-linux install-root/nix-installer.sh
       - name: Initial install
         uses: DeterminateSystems/nix-installer-action@main
diff --git a/.github/workflows/release-branches.yml b/.github/workflows/release-branches.yml
@@ -17,20 +17,12 @@ permissions:
 jobs:
   build-x86_64-linux:
     uses: ./.github/workflows/build-x86_64-linux.yml
-    with:
-      cache-key: release-x86_64-linux-artifacts-${{ github.sha }}
   build-aarch64-linux:
     uses: ./.github/workflows/build-aarch64-linux.yml
-    with:
-      cache-key: release-aarch64-linux-artifacts-${{ github.sha }}
   build-x86_64-darwin:
     uses: ./.github/workflows/build-x86_64-darwin.yml
-    with:
-      cache-key: release-x86_64-darwin-artifacts-${{ github.sha }}
   build-aarch64-darwin:
     uses: ./.github/workflows/build-aarch64-darwin.yml
-    with:
-      cache-key: release-aarch64-darwin-artifacts-${{ github.sha }}
 
   release:
     runs-on: ubuntu-latest
@@ -47,37 +39,28 @@ jobs:
       - name: Create artifacts directory
         run: mkdir -p ./artifacts
 
-      - name: Fetch cached x86_64-linux binary
-        uses: actions/cache/restore@v4
+      - name: Fetch x86_64-linux binary artifact
+        uses: actions/download-artifact@v4
         with:
-          path: nix-installer
-          key: release-x86_64-linux-artifacts-${{ github.sha }}
-      - name: Move artifact to artifacts directory
-        run: mv ./nix-installer ./artifacts/nix-installer-x86_64-linux
-
-      - name: Fetch cached aarch64-linux binary
-        uses: actions/cache/restore@v4
+          name: nix-installer-x86_64-linux
+      - name: Fetch aarch64-linux binary artifact
+        uses: actions/download-artifact@v4
         with:
-          path: nix-installer
-          key: release-aarch64-linux-artifacts-${{ github.sha }}
-      - name: Move artifact to artifacts directory
-        run: mv ./nix-installer ./artifacts/nix-installer-aarch64-linux
-
-      - name: Fetch cached x86_64-darwin binary
-        uses: actions/cache/restore@v4
+          name: nix-installer-aarch64-linux
+      - name: Fetch x86_64-darwin binary artifact
+        uses: actions/download-artifact@v4
         with:
-          path: nix-installer
-          key: release-x86_64-darwin-artifacts-${{ github.sha }}
-      - name: Move artifact to artifacts directory
-        run: mv ./nix-installer ./artifacts/nix-installer-x86_64-darwin
-
-      - name: Fetch cached aarch64-darwin binary
-        uses: actions/cache/restore@v4
+          name: nix-installer-x86_64-darwin
+      - name: Fetch aarch64-darwin binary artifact
+        uses: actions/download-artifact@v4
         with:
-          path: nix-installer
-          key: release-aarch64-darwin-artifacts-${{ github.sha }}
-      - name: Move artifact to artifacts directory
-        run: mv ./nix-installer ./artifacts/nix-installer-aarch64-darwin
+          name: nix-installer-aarch64-darwin
+      - name: Move binaries into upload staging dir
+        run: |
+          mv nix-installer-x86_64-linux artifacts/
+          mv nix-installer-aarch64-linux artifacts/
+          mv nix-installer-x86_64-darwin artifacts/
+          mv nix-installer-aarch64-darwin artifacts/
 
       - name: Configure AWS Credentials
         uses: aws-actions/configure-aws-credentials@v2
diff --git a/.github/workflows/release-prs.yml b/.github/workflows/release-prs.yml
diff --git a/.github/workflows/release-tags.yml b/.github/workflows/release-tags.yml
