Items inside non interactable containers are visible on item finder

[A2ur3]

Disclaimers

• I have searched the issue tracker to check if the issue has already been reported.
• My issue happened while using mods.

What happened?

Items inside non interactable containers are visible on item finder

Reproduction steps

1. add "mountableweapon" tag to exosuit
2. put that exosuit insdie a weapon holder for decoration
3. make the weapon holder non interactable
4. the exosuit is visible on item finder

Bug prevalence

Just once

Single player or multiplayer?

Single player

-

No response

Version

v1.10.7.2 (Autumn Update 2025 Hotfix 4)

-

No response

Which operating system did you encounter this bug on?

Windows

Relevant error messages and crash reports

No response

[Regalis11]

To me this doesn't seem like a bug. The item exists, even if it's somewhere the player can't access.

[A2ur3]

private bool VisibleOnItemFinder(Item targetItem)
{
    if (targetItem?.Submarine == null || item.Submarine == null) { return false; }

    if (!IsPortableItemAllowed) { return false; }

    if (!item.Submarine.IsEntityFoundOnThisSub(targetItem, includingConnectedSubs: true)) { return false; }
    if (targetItem.NonInteractable || targetItem.IsHidden) { return false; }
    if (targetItem.GetComponent<Pickable>() == null) { return false; }

    var holdable = targetItem.GetComponent<Holdable>();
    if (holdable != null && holdable.Attached) { return false; }

    var wire = targetItem.GetComponent<Wire>();
    if (wire != null && wire.Connections.Any(c => c != null)) { return false; }

    if (targetItem.Container?.GetComponent<ItemContainer>() is { DrawInventory: false } or { AllowAccess: false }) { return false; }

    if (targetItem.HasTag(Tags.TraitorMissionItem)) { return false; }

    return true;
}

if (targetItem.NonInteractable || targetItem.IsHidden) { return false; }
if (targetItem.Container?.GetComponent<ItemContainer>() is { DrawInventory: false } or { AllowAccess: false }) { return false; }

I can argue that these inaccessible items exist too, but there's no reason to show inaccessible items on the item finder

[Krzeszny]

I agree, if it's only for decoration and can't be used whatsoever, there's no point in showing it.

[Regalis11]

Yeah, I suppose you have a point. :) I think there might be some cases where someone would want the items to be visible for some reason, but these sort of decorative items are probably by far the most common use for this functionality. I'll convert this to a ticket, we'll look into it!

[Regalis11]

Addressed in https://github.com/FakeFishGames/Barotrauma-development/commit/42e9be9d1f0ec3de904ed24a3b0a288a1e099d60 (commit in our private repo), fix coming up in a future unstable build and update.