-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Added basic spoken language badges #894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Added Arabic, Chinese, English, French, German, Hindi, Portuguese, Russian, and Spanish as badges.
Added speaking emoji for the languages section
Removed unnecessary hashtags and parentheses.
Removed unnecessary extra language category I accidentally made
Clarified that "Languages" meant "Spoken Languages" and moves it to it's appropriate spot.
Jukelyn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are many unrelated lines being changed here.
|
Like what? I outlined what I changed and why in the description. Specifying would be helpful. |
I apologize, I misunderstood what you wrote, I thought you were referring to moving the new category instead! But I see that you renamed and moved the Languages and then added the spoken languages in as well. |
|
Could you resolve the conflicts and then we can go ahead about merging this. Thanks! |
|
This change will likely cause a bunch of the other PRs to have conflicts and so I'll save this one for later. |
I added Arabic, Chinese, English, French, German, Hindi, Portuguese, Russian, and Spanish badges under the "Spoken Language category.
The languages within the category and the category itself are both arranged alphabetically.
I also clarified/edited the old "Languages" tab to mean and say "Programming Languages". I moved this "new" category to it's appropriate spot as well.