chore!: EXPOSED-727 Change timestamp column type for H2 from "DATETIME(9)" to "TIMESTAMP(9)" #2401
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joc-a
force-pushed
the
joc/exposed-727
branch
7 times, most recently
from
c72a332 to
bce334d
Compare
…E(9)" to "TIMESTAMP(9)" This is a preparation step that makes detecting column type change for migration easier.
joc-a
force-pushed
the
joc/exposed-727
branch
from
bce334d to
e0cb879
Compare
joc-a
commented
Feb 10, 2025
| run: | | ||
| # Regex for Conventional Commits specification | ||
| COMMIT_REGEX="^(build|chore|ci|docs|feat|fix|perf|refactor|revert|style|test)(\([^\)]*\))?:\s?(EXPOSED-[0-9]+\s?)?.+$" | ||
| COMMIT_REGEX="^(build|chore|ci|docs|feat|fix|perf|refactor|revert|style|test)(!)?(\([^\)]*\))?:\s?(EXPOSED-[0-9]+\s?)?.+$" |
Contributor
Author
There was a problem hiding this comment.
Modified regular expression to allow for optional "!" (to denote breaking changes) after the commit type
joc-a
commented
Feb 10, 2025
| # Get the PR title | ||
| PR_TITLE="${{ github.event.pull_request.title }}" | ||
| PR_TITLE_REGEX="^(build|chore|ci|docs|feat|fix|perf|refactor|revert|style|test)(!)?(\([^\)]*\))?:\s?(EXPOSED-[0-9]+\s?)?.+$" |
Contributor
Author
There was a problem hiding this comment.
Modified regular expression to allow for optional "!" (to denote breaking changes) after the commit type
joc-a
commented
Feb 10, 2025
Comment on lines
+28
to
+29
| env: | ||
| PR_TITLE: ${{ github.event.pull_request.title }} |
Contributor
Author
There was a problem hiding this comment.
obabichevjb
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary of the change: Change timestamp column type for H2 from "DATETIME(9)" to "TIMESTAMP(9)"
Detailed description:
Overrided
timestampType()inH2DataTypeProviderType of Change
Please mark the relevant options with an "X":
Updates/remove existing public API methods:
Affected databases:
Checklist
Related Issues