-
Notifications
You must be signed in to change notification settings - Fork 753
test: EXPOSED-941 Bump to JUnit 5 in all test suites & JUnit 6 where possible #2668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@e5l This PR might not be fully ready 🤔 I'm trying to understand this successful build that is showing a significant drop in test amount, but took almost 20 minutes longer overall. But it's so slow, I'm wondering if there's an extra setup step I've missed. |
a07c3e7 to
b952ca7
Compare
|
I added the platform launcher to check but the successful build is consistent. The only place I haven't looked is in TC config itself, to see if it has some setting for how tests are being counted/reported, or if there's some way to ungroup them. I'm looking into the failing Detekt btw. Passes locally & message is unhelpful, so I have to pass through to confirm. |
e5l
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
- Fix broken build.gradle.kts
…possible - Fix unresolved issue with PGobject
- Fix initialization errors with non-R2DBC TestDB
- Add platform launcher to dependencies - Exclude H2 dialect modes from running Spring tests
- Fix detekt & rebase issues
b952ca7 to
61e57c2
Compare

Description
Summary of the change:
org.junit.*(JUnit 4) to at minimumorg.junit.jupiter.*(JUnit 5)Detailed description:
Why: Predominantly to align with new minimum requirements for upcoming Spring Framework 7 bump.
How:
exposed-testsandexposed-r2dbc-testsnow depend on JUnit 5.org.junit.Testwithorg.junit.jupiter.api.Test@Before&@Afterwith@BeforeEach&@AfterEachAssume&AssertwithAssumptions&AssertionsTemporaryFolder()rule to@TempDir@ParameterizedClass@Test(expected = …)withAssert.assertThrows@Test(timeout = ...)with@Timeout@RepeatedTestCoroutinesTimeout()rule (different workarounds depending on case)@RunWith(SpringJUnit4ClassRunner::class)with@ExtendWith(SpringExtension::class)@FixMethodOrderwith@TestMethodOrderspring-transaction,exposed-spring-boot-starter, &exposed-cryptnow depend on JUnit 6.Type of Change
Please mark the relevant options with an "X":
Affected databases:
Checklist
Related Issues
EXPOSED-946
EXPOSED-941