B #6772: Fix for NUMA and CPU Pinning Discrepancies During VM Save and Live Migration #6773
Conversation
feldsam
force-pushed
the
feldsam/enhanced-migrate-numa-vms
branch
from
aabbba2 to
4764133
Compare
feldsam
force-pushed
the
feldsam/enhanced-migrate-numa-vms
branch
4 times, most recently
from
b480272 to
5988ca9
Compare
…VM Save and Live Migration Signed-off-by: Kristian Feldsam <[email protected]>
feldsam
force-pushed
the
feldsam/enhanced-migrate-numa-vms
branch
from
5988ca9 to
24b109d
Compare
Signed-off-by: Kristian Feldsam <[email protected]>
feldsam
force-pushed
the
feldsam/enhanced-migrate-numa-vms
branch
from
41d119e to
114b5b8
Compare
| os.str(""); | ||
|
|
||
| //Generate VM description file | ||
| os << "Generating migrate file: " << vm->get_migrate_file(); |
There was a problem hiding this comment.
Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.
Potential log injection detected. Ensure all untrusted input is properly sanitized before logging. Use parameterized logging or validate input against an allow list to prevent log injection vulnerabilities. Consider using a dedicated logging library's built-in sanitization features when available. Learn more - https://cwe.mitre.org/data/definitions/117.html
| goto error_common; | ||
|
|
||
| error_file: | ||
| os << "migrate_action, error generating migrate file: " |
There was a problem hiding this comment.
Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.
Potential log injection detected. Ensure all untrusted input is properly sanitized before logging. Use parameterized logging or validate input against an allow list to prevent log injection vulnerabilities. Consider using a dedicated logging library's built-in sanitization features when available. Learn more - https://cwe.mitre.org/data/definitions/117.html
| //Generate VM description file | ||
| os << "Generating migrate file: " << vm->get_migrate_file(); | ||
|
|
||
| vm->log("VMM", Log::INFO, os); |
There was a problem hiding this comment.
Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.
Potential log injection detected. Ensure all untrusted input is properly sanitized before logging. Use parameterized logging or validate input against an allow list to prevent log injection vulnerabilities. Consider using a dedicated logging library's built-in sanitization features when available. Learn more - https://cwe.mitre.org/data/definitions/117.html
| //Generate VM description file | ||
| os << "Generating migrate file: " << vm->get_migrate_file(); | ||
|
|
||
| vm->log("VMM", Log::INFO, os); |
There was a problem hiding this comment.
Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.
Potential log injection detected. Ensure all untrusted input is properly sanitized before logging. Use parameterized logging or validate input against an allow list to prevent log injection vulnerabilities. Consider using a dedicated logging library's built-in sanitization features when available. Learn more - https://cwe.mitre.org/data/definitions/117.html
| ds_id = vm->get_previous_ds_id(); | ||
|
|
||
| //Generate VM description file | ||
| os << "Generating migrate file: " << vm->get_migrate_file(); |
There was a problem hiding this comment.
Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.
Potential log injection detected. Ensure all untrusted input is properly sanitized before logging. Use parameterized logging or validate input against an allow list to prevent log injection vulnerabilities. Consider using a dedicated logging library's built-in sanitization features when available. Learn more - https://cwe.mitre.org/data/definitions/117.html
| goto error_common; | ||
|
|
||
| error_file: | ||
| os << "save_action, error generating migrate file: " |
There was a problem hiding this comment.
Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.
Potential log injection detected. Ensure all untrusted input is properly sanitized before logging. Use parameterized logging or validate input against an allow list to prevent log injection vulnerabilities. Consider using a dedicated logging library's built-in sanitization features when available. Learn more - https://cwe.mitre.org/data/definitions/117.html
3 participants
Description
This pull request addresses the issue with NUMA node and CPU pinning inconsistencies that occur during VM save and live migration. The migration process has been updated to ensure proper NUMA topology and CPU pinning adjustments, even for pinned VMs. Specifically, during save and live migration operations, the updated NUMA topology is now correctly passed using the --xml option, aligning the VM's configuration with the target host's resources.
Branches to which this PR applies