Skip to content

Conversation

@ncdiehl11
Copy link
Collaborator

@ncdiehl11 ncdiehl11 commented Dec 4, 2025

Overview

With the decision to treat Quick Transfer protocols more like standard protocols, we want to show them in the desktop app's RecentProtocolRuns component. This also allows us to view and download any files from the run, which as of now would include photos taken during any potential error recovery.

There are also a few instances in ODD where we implicitly delete QT runs. We don't want to do this!

Closes EXEC-2090

Test Plan and Hands on Testing

Desktop

  • created and ran a quick transfer protocol
  • on the used device's recent protocol runs section, verified that the quick transfer run is present
Screenshot 2025-12-04 at 1 18 34 PM
  • added unit tests

ODD

  • remove implicit QT run deletions

Changelog

  • remove filter for runs with protocols of type quick-transfer in desktop RecentProtocolRuns and ODD RobotDashboard
  • remove quick transfer run deletion on run cancellation

Review requests

See test plan. Please make sure the changes to ODD reflect the intention of the ticket.

Risk assessment

lowish

With the decision to treat Quick Transfer protocols more like standard protocols, we want to show them in the desktop app's `RecentProtocolRuns` component. This also allows us to view and download any files from the run, which as of now would include photos taken during any potential error recovery.

Closes EXEC-2090
@ncdiehl11 ncdiehl11 requested a review from mjhuff December 4, 2025 21:42
@ncdiehl11 ncdiehl11 marked this pull request as ready for review December 4, 2025 21:43
@ncdiehl11 ncdiehl11 self-assigned this Dec 4, 2025
Copy link
Contributor

@mjhuff mjhuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wooooo, thank you! Glad this was straightforward.

@ncdiehl11 ncdiehl11 merged commit 00efdfe into edge Dec 5, 2025
36 checks passed
sfoster1 pushed a commit that referenced this pull request Dec 8, 2025
With the decision to treat Quick Transfer protocols more like standard
protocols, we want to show them in the desktop app's
`RecentProtocolRuns` component. This also allows us to view and download
any files from the run, which as of now would include photos taken
during any potential error recovery.

There are also a few instances in ODD where we implicitly delete QT
runs. We don't want to do this!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants