Skip to content

Conversation

@koji
Copy link
Contributor

@koji koji commented Dec 7, 2025

Overview

update Storybook from version 7 to version 8.
this pr needs pnpm.

  • import change
    import type { Meta, Story } from '@storybook/react' -> import type { Meta, StoryFn } from '@storybook/react'

  • type check
    some stories need to update because of type things

the version will be updated to 9 / 10 if we need.

Test Plan and Hands on Testing

  • make -C components dev
    check Storybook works as well as version 7

Changelog

  • update Storybook version from 7 to 8
  • update stories

Review requests

  • What do you need from reviewers to feel confident this PR is ready to merge?
  • Ask questions.

Risk assessment

low

koji added 2 commits December 6, 2025 21:13
update Storybook version from v7 to v8
update Storybook from v7 to v8
@codecov
Copy link

codecov bot commented Dec 7, 2025

Codecov Report

❌ Patch coverage is 0% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 24.62%. Comparing base (60f9838) to head (c26c5aa).

Files with missing lines Patch % Lines
.storybook/main.ts 0.00% 12 Missing ⚠️
.storybook/preview.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                       Coverage Diff                        @@
##           chore_change-package-manager   #20314      +/-   ##
================================================================
- Coverage                         24.62%   24.62%   -0.01%     
================================================================
  Files                              3564     3564              
  Lines                            295541   295546       +5     
  Branches                          42503    42503              
================================================================
- Hits                              72774    72773       -1     
- Misses                           222739   222745       +6     
  Partials                             28       28              
Flag Coverage Δ
protocol-designer 19.20% <0.00%> (-0.01%) ⬇️
step-generation 5.59% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
.storybook/preview.tsx 0.00% <0.00%> (ø)
.storybook/main.ts 0.00% <0.00%> (-3.71%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@koji koji marked this pull request as ready for review December 7, 2025 02:42
@koji koji requested a review from a team as a code owner December 7, 2025 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants