place: add "pointer" mode #2912
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
js202510
force-pushed
the
place-pointer
branch
from
30b9fc5 to
4084121
Compare
ammen99
requested changes
Nov 28, 2025
plugins/single_plugins/place.cpp
Outdated
| { | ||
| wf::geometry_t window = view->get_pending_geometry(); | ||
| wf::point_t pos = wf::get_core().get_cursor_position().round_down(); | ||
| window.x = workarea.x + wf::clamp(pos.x - window.width / 2, |
Member
There was a problem hiding this comment.
Prefer std::clamp, we had wf::clamp before moving to a newer C++ version, so it is there just for legacy code.
plugins/single_plugins/place.cpp
Outdated
| void pointer(wayfire_toplevel_view & view, wf::geometry_t workarea) | ||
| { | ||
| wf::geometry_t window = view->get_pending_geometry(); | ||
| wf::point_t pos = wf::get_core().get_cursor_position().round_down(); |
Member
There was a problem hiding this comment.
One thing to keep in mind is multiple outputs. get_core().get_cursor_position() returns the cursor position in the output-layout coordinate system. Views, however, are positioned in output-local coordinate system (i.e relative to their current output). You could look at whether the view is bound to any output (view->get_output(), should be non-null for most views), then use
wayfire/src/api/wayfire/output.hpp
Lines 111 to 114 in 1188a56
Position new windows centered under the mouse pointer, while keeping them fully within the workarea.
js202510
force-pushed
the
place-pointer
branch
from
4084121 to
14e2342
Compare
ammen99
approved these changes
Dec 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new mode to the "place" plug-in to position new windows centered under the mouse pointer, while keeping them fully within the workarea.
The advantage is that the user can control where the new window would be placed by pointing the mouse before starting an app (might be useless when starting apps from a panel, but works well when using wofi or starting apps via key binding, e.g. terminal). And the user can immediately interact with the new window or move it out of the way with minimal mouse effort.
No idea what this would do in a mouseless, touch-screen scenario.