Remove window comparison #2857
Open
Remove window comparison #2857
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
This check is there intentionally. Focus follows mouse should only trigger when a pointer motion moves into a new window, not when it's moving inside an unfocused window, which this PR would change. Regarding your issue, I'll comment there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue lies with if !self.layout.is_overview_open() && current_focus.window.as_ref() != Some(window) in niri.rs 6283. We queried the current PointContents with self.contents_under which ends up being the same as the new_focus var.
Following video shows the fix.
screenrecord.mp4
Fixes #2856