Skip to content

Conversation

@ClaraMuller
Copy link
Contributor

🧭 What and Why

I saw that the final documentation of facets query parameter in Comp API in the documentation is not valid because we made an error in the specs:

Screenshot 2025-12-08 at 13 12 19

Side notes

Changes included:

Put multiple example value according to official documentation: https://swagger.io/docs/specification/v3_0/adding-examples/

🧪 Test

  • CI
  • Run locally yarn cli build specs all && yarn cli build clients javascript

@ClaraMuller ClaraMuller requested a review from a team as a code owner December 8, 2025 12:23
@algolia-bot
Copy link
Collaborator

algolia-bot commented Dec 8, 2025

✔️ Code generated!

Name Link
🪓 Triggered by 4d445dd4dcdb2d61d799ba00607f36d84c8f58e8
🍃 Generated commit 263f428a1c4193d19873e153dc7f99e226e3b1d2
🌲 Generated branch generated/clara/fix/facets-examples
📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Req/s
javascript 2398
go 2304
php 1923
csharp 1529
python 1460
java 1131
ruby 892
swift 715
scala 23

@ClaraMuller ClaraMuller requested a review from a team December 8, 2025 12:51
Copy link
Collaborator

@Fluf22 Fluf22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CODEOWNERS is out of order 😄

@ClaraMuller ClaraMuller merged commit e9c3d79 into main Dec 8, 2025
33 checks passed
@ClaraMuller ClaraMuller deleted the clara/fix/facets-examples branch December 8, 2025 15:56
algolia-bot added a commit that referenced this pull request Dec 8, 2025
… (generated) [skip ci]

Co-authored-by: Clara Muller <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants