Skip to content

Commit c2fa2a5

Browse files
committed
feat: Disable "compile_commands.json" symlink creation by default.
1 parent d191c9e commit c2fa2a5

File tree

6 files changed

+9
-9
lines changed

6 files changed

+9
-9
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -134,7 +134,7 @@ project_options(
134134
${ENABLE_SANITIZER_UNDEFINED_BEHAVIOR}
135135
# ENABLE_SANITIZER_THREAD
136136
# ENABLE_SANITIZER_MEMORY
137-
# DISABLE_COMPILE_COMMANDS_SYMLINK
137+
# ENABLE_COMPILE_COMMANDS_SYMLINK
138138
# ENABLE_PCH
139139
# PCH_HEADERS
140140
# WARNINGS_AS_ERRORS

docs/src/project_options_api.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
- `ENABLE_SANITIZER_UNDEFINED_BEHAVIOR`: Enable undefined behavior sanitizer
1818
- `ENABLE_SANITIZER_THREAD`: Enable thread sanitizer
1919
- `ENABLE_SANITIZER_MEMORY`: Enable memory sanitizer
20-
- `DISABLE_COMPILE_COMMANDS_SYMLINK`: Disable compile_commands.json symlink creation
20+
- `ENABLE_COMPILE_COMMANDS_SYMLINK`: Enable compile_commands.json symlink creation
2121
- `ENABLE_PCH`: Enable Precompiled Headers
2222
- `ENABLE_INCLUDE_WHAT_YOU_USE`: Enable static analysis with include-what-you-use
2323
- `ENABLE_GCC_ANALYZER`: Enable static analysis with GCC (10+) analyzer

docs/src/project_options_example.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ project_options(
9292
${ENABLE_SANITIZER_UNDEFINED_BEHAVIOR}
9393
# ENABLE_SANITIZER_THREAD
9494
# ENABLE_SANITIZER_MEMORY
95-
# DISABLE_COMPILE_COMMANDS_SYMLINK
95+
# ENABLE_COMPILE_COMMANDS_SYMLINK
9696
# ENABLE_PCH
9797
# PCH_HEADERS
9898
# WARNINGS_AS_ERRORS

src/Common.cmake

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ macro(set_project_options_src_dir)
1212
endmacro()
1313

1414
# Common project settings run by default for all the projects that call `project_options()`
15-
macro(common_project_options DISABLE_COMPILE_COMMANDS_SYMLINK)
15+
macro(common_project_options ENABLE_COMPILE_COMMANDS_SYMLINK)
1616
set_project_options_src_dir()
1717
message(DEBUG "${ProjectOptions_SRC_DIR}")
1818

@@ -74,7 +74,7 @@ macro(common_project_options DISABLE_COMPILE_COMMANDS_SYMLINK)
7474
# Enable generate compile_commands.json
7575
set(CMAKE_EXPORT_COMPILE_COMMANDS ON)
7676

77-
if(NOT ${DISABLE_COMPILE_COMMANDS_SYMLINK})
77+
if(${ENABLE_COMPILE_COMMANDS_SYMLINK})
7878
# Make a symbol link of compile_commands.json on the source dir to help clang based tools find it
7979
if(WIN32)
8080
# Detect whether cmake is run as administrator (only administrator can read the LOCAL SERVICE account reg key)

src/DynamicProjectOptions.cmake

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ macro(dynamic_project_options)
7575
"0\;ENABLE_SANITIZER_UNDEFINED_BEHAVIOR\;OFF\;${SUPPORTS_UBSAN}\;Make certain types (numeric mostly) of undefined behavior into runtime errors"
7676
"0\;ENABLE_SANITIZER_THREAD\;OFF\;OFF\;Make thread race conditions into hard runtime errors"
7777
"0\;ENABLE_SANITIZER_MEMORY\;OFF\;OFF\;Make other memory errors into runtime errors"
78-
"0\;DISABLE_COMPILE_COMMANDS_SYMLINK\;OFF\;OFF\;Don't create a symlink for compile_commands.json"
78+
"0\;ENABLE_COMPILE_COMMANDS_SYMLINK\;OFF\;OFF\;Don't create a symlink for compile_commands.json"
7979
"1\;LINKER\;\;\;Choose a specific linker"
8080
"1\;VS_ANALYSIS_RULESET\;\;\;Override the defaults for the code analysis rule set in Visual Studio"
8181
"1\;CONAN_PROFILE\;\;\;Use specific Conan profile"
@@ -205,7 +205,7 @@ macro(dynamic_project_options)
205205
${ENABLE_SANITIZER_UNDEFINED_BEHAVIOR_VALUE}
206206
${ENABLE_SANITIZER_THREAD_VALUE}
207207
${ENABLE_SANITIZER_MEMORY_VALUE}
208-
${DISABLE_COMPILE_COMMANDS_SYMLINK_VALUE}
208+
${ENABLE_COMPILE_COMMANDS_SYMLINK_VALUE}
209209
${LINKER_VALUE}
210210
${VS_ANALYSIS_RULESET_VALUE}
211211
${CONAN_PROFILE_VALUE}

src/Index.cmake

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ macro(project_options)
6767
ENABLE_SANITIZER_UNDEFINED_BEHAVIOR
6868
ENABLE_SANITIZER_THREAD
6969
ENABLE_SANITIZER_MEMORY
70-
DISABLE_COMPILE_COMMANDS_SYMLINK)
70+
ENABLE_COMPILE_COMMANDS_SYMLINK)
7171
set(oneValueArgs
7272
PREFIX
7373
LINKER
@@ -101,7 +101,7 @@ macro(project_options)
101101
set(WARNING_MESSAGE WARNING)
102102
endif()
103103

104-
common_project_options(${ProjectOptions_DISABLE_COMPILE_COMMANDS_SYMLINK})
104+
common_project_options(${ProjectOptions_ENABLE_COMPILE_COMMANDS_SYMLINK})
105105

106106
# Add an interface library for the options
107107
set(_options_target project_options)

0 commit comments

Comments
 (0)