[AAP-44277] License module now validates API responses for subscription IDs. (Moved from Tower) (#16096)

* resolve bug and add simple unit tests

* Update awx_collection/plugins/modules/license.py

Co-authored-by: Andrew Potozniak <[email protected]>

---------

Co-authored-by: Andrew Potozniak <[email protected]>

Author: arrestle

awx_collection/plugins/modules/license.py

@@ -67,6 +67,7 @@
 '''
 
 import base64
+
 from ..module_utils.controller_api import ControllerAPIModule
 
 
@@ -120,11 +121,17 @@ def main():
 
     # Do the actual install, if we need to
     if perform_install:
-        json_output['changed'] = True
         if module.params.get('manifest', None):
-            module.post_endpoint('config', data={'manifest': manifest.decode()})
+            response = module.post_endpoint('config', data={'manifest': manifest.decode()})
         else:
-            module.post_endpoint('config/attach', data={'subscription_id': module.params.get('subscription_id')})
+            response = module.post_endpoint('config/attach', data={'subscription_id': module.params.get('subscription_id')})
+
+        # Check API response for errors (AAP-44277 fix)
+        if response and response.get('status_code') and response.get('status_code') != 200:
+            error_msg = response.get('json', {}).get('error', 'License operation failed')
+            module.fail_json(msg=error_msg)
+
+        json_output['changed'] = True
 
     module.exit_json(**json_output)
 

awx_collection/test/awx/test_license_subscription.py

@@ -0,0 +1,32 @@
+from __future__ import absolute_import, division, print_function
+
+__metaclass__ = type
+
+import pytest
+
+
+@pytest.mark.django_db
+def test_license_invalid_subscription_id_should_fail(run_module, admin_user):
+    """Test invalid subscription ID returns failure."""
+    result = run_module('license', {'subscription_id': 'invalid-test-12345', 'state': 'present'}, admin_user)
+
+    assert result.get('failed', False)
+    assert 'msg' in result
+    assert 'subscription' in result['msg'].lower()
+
+
+@pytest.mark.django_db
+def test_license_invalid_manifest_should_fail(run_module, admin_user):
+    """Test invalid manifest returns failure."""
+    result = run_module('license', {'manifest': '/nonexistent/test.zip', 'state': 'present'}, admin_user)
+
+    assert result.get('failed', False)
+    assert 'msg' in result
+
+
+@pytest.mark.django_db
+def test_license_state_absent_works(run_module, admin_user):
+    """Test license removal works."""
+    result = run_module('license', {'state': 'absent'}, admin_user)
+
+    assert not result.get('failed', False)