Skip to content

Conversation

@AlanCoding
Copy link
Member

SUMMARY

This is another downstream test fix for ansible/django-ansible-base#749

Basically, the API became slightly more strict in that patch, and we're using real API slugs for related references. This fixes a sloppy pattern the test previously had.

By merging this, the DAB checks may pass.

ISSUE TYPE
  • Bug, Docs Fix or other nominal change
COMPONENT NAME
  • API

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 8, 2025

@codecov
Copy link

codecov bot commented Jul 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.48%. Comparing base (bf0567c) to head (91ea810).
⚠️ Report is 264 commits behind head on devel.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tvo318
Copy link
Member

tvo318 commented Jul 11, 2025

@AlanCoding these two don't seem consistent. Perhaps just my ignorance of the intent, but the first line breaks into multiple lines while the 2nd one, all the syntax is contained in one single line.

@djulich
Copy link
Contributor

djulich commented Jul 11, 2025

@AlanCoding these two don't seem consistent. Perhaps just my ignorance of the intent, but the first line breaks into multiple lines while the 2nd one, all the syntax is contained in one single line.

I think the line breaks have been introduced to satisfy the CI linter because the added "awx." pushed the line length above the limit (of 160 chars, I suppose).

@AlanCoding
Copy link
Member Author

I think the line breaks have been introduced to satisfy the CI linter because the added "awx." pushed the line length above the limit (of 160 chars, I suppose).

Yes, that's my understanding that this is just something black did.

awx-operator check is failing so I'll poke that and return to this in a bit.

@AlanCoding
Copy link
Member Author

operator check resolved with a rerun. Thanks.

@AlanCoding AlanCoding merged commit 7977e86 into ansible:devel Jul 14, 2025
37 of 40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants