Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
From my data, 4 out of 10,000 test runs will fail with a "DID NOT RAISE" assertion, which is an unintended flaky fail.
While 0.04% is pretty low, we actually have several documented instances of this. So this should take care of it.
ISSUE TYPE
COMPONENT NAME
Note
Reduces flakiness in
test_random_titles_generates_correct_charactersby retryingrandom_title(non_ascii=True)multiple times before asserting an ASCII encode failure.awxkit/test/test_utils.py, maketest_random_titles_generates_correct_charactersmore robust by looping retries ofutils.random_title(non_ascii=True)(up to 4 times) before expectingUnicodeEncodeErroron ASCII encoding.Written by Cursor Bugbot for commit d14e6f6. This will update automatically on new commits. Configure here.