auv task basher666 #41
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icyflame
requested changes
Feb 22, 2017
| <!-- Use build_depend for packages you need at compile time: --> | ||
| <!-- <build_depend>message_generation</build_depend> --> | ||
| <!-- Use buildtool_depend for build tool packages: --> | ||
| <!-- <buildtool_depend>catkin</buildtool_depend> --> |
Member
There was a problem hiding this comment.
Please clean up this file so that only the required lines are visible. Tag explanation is not required. 🙂
| #include "ros/ros.h" | ||
| #include "std_msgs/Int64.h" | ||
| #include <sstream> | ||
| #include <bits/stdc++.h> |
Member
There was a problem hiding this comment.
You need not import everything. Very few functions are required for this node, and it makes sense to import only those header files which are actually required.
| @@ -0,0 +1,30 @@ | |||
| #include "ros/ros.h" | |||
| #include "std_msgs/Int64.h" | |||
| #include <bits/stdc++.h> | |||
| @@ -0,0 +1,34 @@ | |||
| #include "ros/ros.h" | |||
| #include "std_msgs/Int64.h" | |||
| #include <bits/stdc++.h> | |||
| ros::Rate loop_rate(1); | ||
| sq_pub=n2.advertise<std_msgs::Int64>("topic_squares",1000); //selecting topic_squares as the topic to publish | ||
| ros::Subscriber square=n.subscribe("topic_numbers",1000,numberscallback); //selecting topic_numbers as the topic to subscribe | ||
| ROS_INFO("hahahaha \n"); |
Member
There was a problem hiding this comment.
You can remove debug print statements from the submission 😄
Author
|
done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is the completed assignment 1 task from basher666(Swastik Haldar)