(VIBE CODED) Fix GTK authentication window not closing automatically #1065
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The GTK window would remain open after authentication completed because it never detected when compare.py finished. Changes: - authsticky.py: Detect EOF on stdin and exit gracefully when the parent process closes the pipe - compare.py: Properly close stdin and wait for GTK process to exit before force-killing it This ensures the authentication window closes automatically instead of requiring the user to manually click to close it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I used Claude Code for this. It fixed the issue for me but I can't vouch for the code. I don't know the codebase and I don't know python too well. But the diff is small enough that hopefully you won't mind looking it over.
It did fix the issue though. At first (after installing from source and spending a LOT of time trying to get it to find dlib) the UI window would just stay open. This seems to have solved that.
AI DESCRIPTION:
The GTK window would remain open after authentication completed because it never detected when compare.py finished.
Changes:
This ensures the authentication window closes automatically instead of requiring the user to manually click to close it.