Thoughts on using spinner for HTTP download progress indicator?

[andyfeller]

Question

How might someone already using briandowns/spinner incorporate it in HTTP downloads where the Prefix / Suffix needed to be dynamic?

Thoughts

During the course of cli/cli#8536, someone brought up https://github.com/schollz/progressbar for displaying a progress indicator around HTTP downloads. Apparently, it works through the use of io.MultiWriter to provide the IO stream, which is configured with information on the total number of bytes.

I thought this might be in briandowns/spinner wheelhouse and potentially doable through the PreUpdate func(s *Spinner) hook:

spinner/spinner.go

Lines 349 to 363 in 5543086

	if s.PreUpdate != nil {
	s.PreUpdate(s)
	}
	var outColor string
	if isWindows {
	if s.Writer == os.Stderr {
	outColor = fmt.Sprintf("\r%s%s%s", s.Prefix, s.chars[i], s.Suffix)
	} else {
	outColor = fmt.Sprintf("\r%s%s%s", s.Prefix, s.color(s.chars[i]), s.Suffix)
	}
	} else {
	outColor = fmt.Sprintf("\r%s%s%s", s.Prefix, s.color(s.chars[i]), s.Suffix)
	}
	outPlain := fmt.Sprintf("\r%s%s%s", s.Prefix, s.chars[i], s.Suffix)

Maybe the caller constructs an anonymous function that involves a similar io.MultiWriter with the content size to generate an updated Prefix?

Thanks

❤️ Finally, I just want to thank you on behalf of the GitHub CLI as your project has helped our users for several years now, @briandowns! 🙇