feat: support KMS master key id to encrypt SNS topic #73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msrdjan
changed the title
|
@msrdjan can you take a look at the linters? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
Add
kms_master_key_idvariable to be set for theaws_sns_topicresource (default isnull, usually set toalias/aws/snsfor AWS managed AWS KMS for Amazon SNS).Note: Reopening the PR after rebasing to latest main and resolving conflicts as asked in #66 (comment) by @cloudposse-mergebot.
why
To protect the contents of messages in Amazon SNS topics using keys managed in AWS Key Management Service (AWS KMS).
Resolves Topic does not have encryption enabled
AVD-AWS-0095.references
AVD-AWS-0095