🗑️ service: obsolete global stats config

Simplify things by turning on stats when API is enabled.

Author: database64128

service/server.go

@@ -321,7 +321,7 @@ type ServerConfig struct {
 }
 
 // Initialize initializes the server configuration.
-func (sc *ServerConfig) Initialize(tlsCertStore *tlscerts.Store, listenConfigCache conn.ListenConfigCache, collector stats.Collector, router *router.Router, logger *zap.Logger, index int) error {
+func (sc *ServerConfig) Initialize(tlsCertStore *tlscerts.Store, listenConfigCache conn.ListenConfigCache, statsConfig stats.Config, router *router.Router, logger *zap.Logger, index int) error {
 	sc.tcpEnabled = sc.EnableTCP || len(sc.TCPListeners) > 0
 	sc.udpEnabled = sc.EnableUDP || len(sc.UDPListeners) > 0
 
@@ -388,7 +388,7 @@ func (sc *ServerConfig) Initialize(tlsCertStore *tlscerts.Store, listenConfigCac
 
 	sc.tlsCertStore = tlsCertStore
 	sc.listenConfigCache = listenConfigCache
-	sc.collector = collector
+	sc.collector = statsConfig.Collector()
 	sc.router = router
 	sc.logger = logger
 	sc.index = index

service/service.go

@@ -158,11 +158,16 @@ func (sc *Config) Manager(logger *zap.Logger) (*Manager, error) {
 	}
 
 	credman := cred.NewManager(logger)
-	var apiSM *ssm.ServerManager
-
 	services = append(services, credman)
 
+	var (
+		apiSM       *ssm.ServerManager
+		statsConfig stats.Config
+	)
+
 	if sc.API.Enabled {
+		statsConfig.Enabled = true
+
 		var apiServer *api.Server
 		apiServer, apiSM, err = sc.API.NewServer(logger, listenConfigCache, tlsCertStore)
 		if err != nil {
@@ -173,8 +178,8 @@ func (sc *Config) Manager(logger *zap.Logger) (*Manager, error) {
 
 	for i := range sc.Servers {
 		serverConfig := &sc.Servers[i]
-		collector := sc.Stats.Collector()
-		if err := serverConfig.Initialize(tlsCertStore, listenConfigCache, collector, router, logger, i); err != nil {
+
+		if err := serverConfig.Initialize(tlsCertStore, listenConfigCache, statsConfig, router, logger, i); err != nil {
 			return nil, fmt.Errorf("failed to initialize server %q: %w", serverConfig.Name, err)
 		}