Miyoo A30 port

[acrocosm]

Please port this to Miyoo A30. The game seems to work, you can hear the music, you can start a game, it is just that the screen is black. I tested the Miyoo Mini versions and both OnionOS and MinUI seem fine but with black screen. Apparently the A30 has a portrait screen with a resolution of 480x640 instead of the expected landscape 640x480 and this seems to be the reason it is black. It should be an easy and fast fix!

[AJenbo]

It's hard to fix for anyone that does not have the device.

[StephenCWills]

It should be an easy and fast fix!

How do you know that? Have you fixed it before for another game? We appreciate contributions from the community.

[acrocosm]

Ah, I guess you are right, it would be hard for anyone not owning the device. And no, I do not know that it is an easy and fast fix, it is just a logical assumption based on my tests with the Miyoo Mini versions and my vague memory that the A30 uses a portrait screen, given that everything seems to work fine, except display. I guess I should rephrase that to "blah, blah, if that's the case, then it should be an easy and fast fix" :)
I am willing to test, I can tell that much, I tried getting the source code to see I can do anything but got lost along the way. No, I have not done anything like that before. I may attempt it again when I have more time and I'm more focused. Meanwhile, if anyone who already knows the project and has free time feels adventurous, that would be a blessing.

[AJenbo]

I guess your point is that it's apparently the only issue one would need to solve so easy compared to something where nothing works.

The psp port is an interesting comparison, everything works, but fps is low and rendering will have to be completely rewritten, something that was only evident after we solved all other issues, porting is tricky sometimes.

I have no idea how we would rotate the screen, and If doing so can be done without hurting performance, usually it's handled by the SDL port for the specific platform so maybe it's simply a question of building against the devices sdk. If it was just screen rotation I would expect to see the game already so probably the screen is accessed differently then the other devices, again this is something SDL should abstract for us. I would suggest you look into locating the toolchain for the device and we can help you with how to build the game and that's the most likely solution to the screen problem, if not then you need to find someone with an understanding of how to display things on this device.

It's not simply "setting the wrong display values" and getting "out of range" the way it works we ask for a best fit surface to draw on and accept what is returned, we do not directly set display modes.

[acrocosm]

I tried to compile it using hydrogen18's toolchain and sdl2. There were quite a few dependence missing but after many hours i managed to compile it without errors but quite a few warnings. The executable would crash instantly though when I try to run it.

So next then tried to work with union-toolchain again, updating gcc and cmake to be able to compile successfully. But that also lead to the same result, the game crashes as soon as i start it. This is different than how the latest releases behave. I did not try to change anything in the source code, just compile it. Like I said i haven't done anything like that before, I hadn't even used docker. I spend 2 days with minimal sleep. Can you help me compile the current release in a way that it runs as well with just the screen problem please?

[acrocosm]

I see, the iceberg is invisible, I only see the tip. Thanks you so much for taking the time to write such a detailed reply.

I did some digging and thinking and found out this blog post about the a30 screen. Do you recon it would be feasible to write a simple sdl launcher for the game that captures render output, rotates it and displays it as a texture?

[acrocosm]

Thank you both so much <3
I found the color order in /source/engine/palette.cpp, swapped R and B and build it. It worked nicely and the colors were fixed. In the end though I build steward-fu's libSDL and that worked as a drop in replacement with the current release. Much cleaner, no modifications needed. There's a slight glitch with the quick use items, where if you use one they linger flashing until you load another area of add another item in that slot, but hey!

[acrocosm]

Here is a dirty package if anyone wants to try.

devilutionx-miyoo-a30-spruceos.zip

[parataxia]

Thanks for fixing this, I thought maybe it was related to bit depth or possibly libsdl incompatibility, like you said portrait.

[parataxia]

BTW I adjusted the script to allow the analog to work as D-pad:

#!/bin/sh

cd "$(dirname "$0")"

if [ -f "Diablo/DIABDAT.MPQ" ] || [ -f "Diablo/spawn.mpq" ]; then
	kill -STOP `pidof MainUI`
	export LD_LIBRARY_PATH=./Diablo/lib/
	killall -q -USR2 joystickinput
	./Diablo/devilutionx
	kill -CONT `pidof MainUI`
	killall -q -USR1 joystickinput
else
	# show "okay.png"
	say "Missing DIABDAT.MPQ!"$'\n\n'"Please see readme.txt"$'\n'"in the Diablo folder"$'\n'"on your SD card."$'\n'
	confirm only
fi

[acrocosm]

Awesome, thank you so much!