[devops] Move check for hard disk space to the setup logic. #24364
Conversation
This way we always check for available hard disk space (currently we don't check for the API Diff pipeline).
There was a problem hiding this comment.
Pull request overview
This PR refactors the hard disk space checking logic by moving it from individual pipeline templates into the centralized setup.yml template. This ensures that disk space is checked consistently across all pipelines that use the setup template, including the API Diff pipeline which previously lacked this check.
Key Changes:
- Centralized disk space check in
common/setup.ymlwith parameterized disk space requirements - Removed duplicate disk space checks from
tests/build.ymlandmac/build.yml - Added
requiredDiskSpaceandstatusContextparameters throughout the template hierarchy
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| tools/devops/automation/templates/common/setup.yml | Added centralized disk space check with parameterized requirements (lines 9-10, 33-46) |
| tools/devops/automation/templates/tests/build.yml | Removed inline disk space check, now passes parameters to setup.yml (lines 88-89) |
| tools/devops/automation/templates/mac/build.yml | Removed inline disk space check (lines 96-98) |
| tools/devops/automation/templates/build/build.yml | Added requiredDiskSpace and statusContext parameters with defaults, passes them to setup.yml |
| tools/devops/automation/templates/build/build-mac-tests.yml | Specified disk space requirement of 10 GB for macOS tests |
| tools/devops/automation/templates/build/api-diff-build-and-detect.yml | Specified disk space requirement of 50 GB for API diff builds |
| tools/devops/automation/templates/tests/stage.yml | Added statusContext parameter forwarding |
| tools/devops/automation/run-nightly-codeql.yml | Added statusContext parameter for CodeQL builds |
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
🔥 [PR Build #d853334] Build failed (Detect API changes) 🔥Build failed for the job 'Detect API changes' (with job status 'Failed') Pipeline on Agent |
|
🔥 Unable to find the contents for the comment: D:\a\1\s\change-detection\results\gh-comment.md does not exist :fire Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ [CI Build #d853334] Build passed (Build packages) ✅Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This way we always check for available hard disk space (currently we don't
check for the API Diff pipeline).