Skip to content

Commit e578822

Browse files
Review feedback
1 parent 860936a commit e578822

File tree

1 file changed

+5
-8
lines changed

1 file changed

+5
-8
lines changed

src/coreclr/tools/Common/Compiler/ObjectWriter/StringTableBuilder.cs

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -141,7 +141,7 @@ static bool MultiKeySortSmallInput(Span<Utf8String> input, int pos)
141141
(input[0], input[1]) = (input[1], input[0]);
142142
break;
143143
}
144-
else if (c0 > c1 || c0 == (char)0)
144+
else if (c0 > c1 || c0 == 0)
145145
{
146146
break;
147147
}
@@ -157,13 +157,10 @@ static bool MultiKeySortSmallInput(Span<Utf8String> input, int pos)
157157
private uint CreateIndex(Utf8String text)
158158
{
159159
uint offset = (uint)_stream.Position;
160-
int reservedBytes = text.Length + 1;
161-
byte[] buffer = ArrayPool<byte>.Shared.Rent(reservedBytes);
162-
var span = new Span<byte>(buffer, 0, reservedBytes);
163-
text.AsSpan().CopyTo(span);
164-
span[reservedBytes - 1] = 0;
165-
_stream.Write(span);
166-
ArrayPool<byte>.Shared.Return(buffer);
160+
161+
_stream.Write(text.AsSpan());
162+
_stream.WriteByte(0);
163+
167164
_stringToOffset[text] = offset;
168165
return offset;
169166
}

0 commit comments

Comments
 (0)