mraa: fix mraa_file_contains() and mraa_file_contains_both() #979
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These two functions may return wrong results if lines in the file contains embedded '\0' characters. For example, file "/proc/device-tree/compatible" could have multiple values in one line (corresponding to the dts), and the values are separated with '\0'. In this situation, we need to replace the embedded '\0' and check the entire line. If we don't do this, only the first value is checked by strstr(), and the function may return false even if the file contains certain content. Signed-off-by: Benxi Liu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These two functions may return wrong results if lines in the
file contains embedded '\0' characters.
For example, file "/proc/device-tree/compatible" could have
multiple values in one line (corresponding to the dts), and the
values are separated with '\0'.
In this situation, we need to replace the embedded '\0' and check
the entire line. If we don't do this, only the first value is
checked by strstr(), and the function may return false even if
the file contains certain content.
Signed-off-by: Benxi Liu [email protected]