Skip to content

Commit 3a6d06b

Browse files
committed
Simple cleanup to improve interop (data first)
1 parent 5a6a5b3 commit 3a6d06b

File tree

3 files changed

+4
-7
lines changed

3 files changed

+4
-7
lines changed

src/Elmish.WPF.Tests/DynamicViewModelTests.fs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -127,7 +127,7 @@ module Helpers =
127127
AutoRequery = autoRequery }
128128
|> CmdData
129129
|> BaseBindingData
130-
|> createBinding) name
130+
|> Binding.createBinding) name
131131

132132

133133
let internal subModel

src/Elmish.WPF/Binding.fs

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,11 +6,12 @@ open Elmish
66

77

88
module Binding =
9+
let internal createBinding data name = { Data = data |> BindingData.boxT; Name = name }
910
open BindingData
1011

1112
let internal mapData f binding =
12-
{ Name = binding.Name
13-
Data = binding.Data |> f }
13+
{ Data = binding.Data |> f
14+
Name = binding.Name }
1415

1516
/// Maps the model of a binding via a contravariant mapping.
1617
let mapModel (f: 'a -> 'b) (binding: Binding<'b, 'msg>) = f |> mapModel |> mapData <| binding

src/Elmish.WPF/DynamicViewModel.fs

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,10 +18,6 @@ type Binding<'model, 'msg> =
1818
[<AutoOpen>]
1919
module internal Helpers =
2020

21-
let createBinding data name =
22-
{ Name = name
23-
Data = data |> BindingData.boxT }
24-
2521
type SubModelSelectedItemLast with
2622
member this.CompareBindings() : Binding<'model, 'msg> -> Binding<'model, 'msg> -> int =
2723
fun a b -> this.Recursive(a.Data) - this.Recursive(b.Data)

0 commit comments

Comments
 (0)