Skip to content

Commit afca94a

Browse files
authored
Merge pull request #227 from entando/ENG-3284-centralize-referenced-artifacts-versions
ENG-3284 Centralize referenced artifacts versions
2 parents 15e98c9 + 3edacf8 commit afca94a

File tree

10 files changed

+15
-9
lines changed

10 files changed

+15
-9
lines changed

generators/generator-constants.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,8 @@ const DEFAULT_SERVER_PROMPTS = {
2323

2424
const SCALA_LIBRARY_VERSION = '2.12.1';
2525
const MBKNOR_JACKSON_JSONSCHEMA_VERSION = '1.0.34';
26-
const ENTANDO_BUNDLE_BOM_VERSION = '7.0.0-ENG-3090-PR-7';
26+
const ENTANDO_BUNDLE_BOM_VERSION = '7.0.0-ENG-3251-PR-9';
27+
const ENTANDO_KEYCLOAK_DOCKER_IMAGE = 'entando/entando-keycloak:7.0.0-ENG-3087-PR-23';
2728

2829
module.exports = {
2930
SQL_DB_OPTIONS,
@@ -35,4 +36,5 @@ module.exports = {
3536
SCALA_LIBRARY_VERSION,
3637
MBKNOR_JACKSON_JSONSCHEMA_VERSION,
3738
ENTANDO_BUNDLE_BOM_VERSION,
39+
ENTANDO_KEYCLOAK_DOCKER_IMAGE,
3840
};

generators/server/index.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@ module.exports = class extends ServerGenerator {
2929
const entandoPhase = {
3030
setupEntandoServerconsts() {
3131
this.ENTANDO_BUNDLE_BOM_VERSION = constants.ENTANDO_BUNDLE_BOM_VERSION;
32+
this.ENTANDO_KEYCLOAK_DOCKER_IMAGE = constants.ENTANDO_KEYCLOAK_DOCKER_IMAGE;
3233
},
3334
};
3435

generators/server/templates/src/main/docker/keycloak.yml.ejs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
version: '<%= DOCKER_COMPOSE_FORMAT_VERSION %>'
2121
services:
2222
keycloak:
23-
image: entando/entando-keycloak:7.0.0-ENG-3087-PR-23
23+
image: '<%= ENTANDO_KEYCLOAK_DOCKER_IMAGE %>'
2424
command: [
2525
'-b',
2626
'0.0.0.0',

test-integration/samples/maven-default-jhipster-bom/.yo-rc.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
"bundleName": "test-bundle",
88
"dockerImageOrganization": "aaaa",
99
"generateMicroFrontends": "always",
10-
"jhipsterVersion": "6.9.0",
10+
"jhipsterVersion": "7.2.0",
1111
"applicationType": "microservice",
1212
"baseName": "test",
1313
"packageName": "com.mycompany.myapp",

test-integration/samples/maven-default-nodb/.yo-rc.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
"bundleName": "test-bundle",
88
"dockerImageOrganization": "aaaa",
99
"generateMicroFrontends": "always",
10-
"jhipsterVersion": "6.9.0",
10+
"jhipsterVersion": "7.2.0",
1111
"applicationType": "microservice",
1212
"baseName": "test",
1313
"packageName": "com.mycompany.myapp",

test-integration/samples/maven-default/.yo-rc.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
"bundleName": "test-bundle",
88
"dockerImageOrganization": "aaaa",
99
"generateMicroFrontends": "always",
10-
"jhipsterVersion": "6.9.0",
10+
"jhipsterVersion": "7.2.0",
1111
"applicationType": "microservice",
1212
"baseName": "test",
1313
"packageName": "com.mycompany.myapp",

test-integration/samples/maven-oracle-hazelcast/.yo-rc.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
"bundleName": "test-bundle",
88
"dockerImageOrganization": "aaaa",
99
"generateMicroFrontends": "always",
10-
"jhipsterVersion": "6.9.0",
10+
"jhipsterVersion": "7.2.0",
1111
"applicationType": "microservice",
1212
"baseName": "test",
1313
"packageName": "com.mycompany.myapp",

test-integration/samples/maven-postgres-redis-jhipster-bom/.yo-rc.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
"bundleName": "test-bundle",
88
"dockerImageOrganization": "aaaa",
99
"generateMicroFrontends": "always",
10-
"jhipsterVersion": "6.9.0",
10+
"jhipsterVersion": "7.2.0",
1111
"applicationType": "microservice",
1212
"baseName": "test",
1313
"packageName": "com.mycompany.myapp",

test-integration/samples/maven-postgres-redis/.yo-rc.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
"bundleName": "test-bundle",
88
"dockerImageOrganization": "aaaa",
99
"generateMicroFrontends": "always",
10-
"jhipsterVersion": "6.9.0",
10+
"jhipsterVersion": "7.2.0",
1111
"applicationType": "microservice",
1212
"baseName": "test",
1313
"packageName": "com.mycompany.myapp",

test/server.spec.js

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,14 @@ const path = require('path');
22
const assert = require('yeoman-assert');
33
const helpers = require('yeoman-test');
44
const constants = require('generator-jhipster/generators/generator-constants');
5+
const entandoConstants = require('../generators/generator-constants');
56
const expectedFiles = require('./utils/expected-files');
67

78
const appBaseName = 'entandoPlugin';
89
const { DOCKER_DIR, SERVER_MAIN_SRC_DIR, SERVER_MAIN_RES_DIR, SERVER_TEST_RES_DIR } = constants;
910

11+
const { ENTANDO_KEYCLOAK_DOCKER_IMAGE } = entandoConstants;
12+
1013
describe('Subgenerator server of entando JHipster blueprint', () => {
1114
describe('With default blueprint configuration', () => {
1215
before(done => {
@@ -199,7 +202,7 @@ describe('Subgenerator server of entando JHipster blueprint', () => {
199202
});
200203

201204
it('Keycloack docker file contains the Entando modifications', () => {
202-
assert.fileContent(`${DOCKER_DIR}keycloak.yml`, 'entando/entando-keycloak:7.0.0-ENG-3087-PR-23');
205+
assert.fileContent(`${DOCKER_DIR}keycloak.yml`, ENTANDO_KEYCLOAK_DOCKER_IMAGE);
203206
assert.fileContent(
204207
`${DOCKER_DIR}keycloak.yml`,
205208
'command: [\n' +

0 commit comments

Comments
 (0)