Make OFValueType extend the Writeable interface. #505
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also made DatapathId implement Writeable. This code passes "make check-all".
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
Indentation was all wonky.
Author
|
Code still passes "make check-all". |
Removed nested scoping blocks and and changed comment.
Author
|
Comment: I see PR #416 adds a new |
Author
|
Reviewer: @andi-bigswitch Andi, this is the PR we discussed at the end of Issue #502. Did you have any comments on the changes? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also makes DatapathId implement Writeable.
New unit tests included. This code passes "make check-all".
Please reference discussion in Issue #502 and Issue #504.