Remove usage of net-disconnect-ok flag. #12342
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copybara-service
bot
force-pushed
the
test/cl838918712
branch
4 times, most recently
from
48eb93e to
4fe1597
Compare
The net-disconnect-ok flag was previously used only to cause a panic in the beforeSave() method of TCP and unix connections if it was set to false. Since this flag is now set to true by default, and this default setting causes TCP and unix connections to always be aborted during the save operation, the flag no longer serves its original purpose of conditionally preventing connection termination. So, the flag's usage is removed. PiperOrigin-RevId: 840433518
copybara-service
bot
force-pushed
the
test/cl838918712
branch
from
4fe1597 to
c0bf129
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove usage of net-disconnect-ok flag.
The net-disconnect-ok flag was previously used only to cause a panic in the
beforeSave() method of TCP and unix connections if it was set to false.
Since this flag is now set to true by default, and this default setting causes
TCP and unix connections to always be aborted during the save operation, the
flag no longer serves its original purpose of conditionally preventing
connection termination. So, the flag's usage is removed.