Merge pull request #7 from helmhub-io/ft/image-migration

fix: pipeline failure and retry logic

Author: UkemeSkywalker

migrate-images.sh

@@ -7,9 +7,6 @@ DEST_USER="helmhubio"
 
 # -------------------------------------------------------------------
 # 🔐 Docker login credentials (set these before running)
-# Example:
-#   export DOCKER_USER="helmhubio"
-#   export DOCKER_PASS="your-access-token"
 # -------------------------------------------------------------------
 
 DOCKER_USER="${DOCKER_USER:-}"
@@ -34,6 +31,26 @@ for cmd in curl jq docker; do
   fi
 done
 
+# -------------------------------------------------------------------
+# 🔁 [NEW] Retry Helper Function
+# -------------------------------------------------------------------
+retry() {
+  local cmd=$1
+  local max_retries=${2:-3}
+  local delay=${3:-5}
+  local count=0
+
+  until eval "$cmd"; do
+    count=$((count + 1))
+    if [ $count -ge $max_retries ]; then
+      echo "❌ Command failed after ${max_retries} attempts: $cmd"
+      return 1
+    fi
+    echo "⚠️  Retry ${count}/${max_retries} for: $cmd (waiting ${delay}s)"
+    sleep "$delay"
+  done
+}
+
 # -------------------------------------------------------------------
 # 🔑 Login to Docker Hub
 # -------------------------------------------------------------------
@@ -53,7 +70,7 @@ URL="https://hub.docker.com/v2/repositories/${SRC_USER}/?page_size=100"
 
 while [ -n "$URL" ] && [ "$URL" != "null" ]; do
   echo "📥 Fetching from: $URL"
-  RESP=$(curl -s "$URL")
+  RESP=$(retry "curl -s \"$URL\"" 3 5)
   NAMES=$(echo "$RESP" | jq -r '.results[].name')
   REPOS+=($NAMES)
   URL=$(echo "$RESP" | jq -r '.next')
@@ -74,15 +91,25 @@ for REPO in "${REPOS[@]}"; do
   echo "🚀 Processing repository: ${REPO}"
 
   TAGS_URL="https://hub.docker.com/v2/repositories/${SRC_USER}/${REPO}/tags?page_size=100"
-  TAGS_JSON=$(curl -s "$TAGS_URL")
+  
+  # [NEW] Retry fetching tags
+  TAGS_JSON=$(retry "curl -s \"$TAGS_URL\"" 3 5)
+
+  # Debug: Show actual API response if it's not valid JSON
+  if [ -z "$TAGS_JSON" ] || ! echo "$TAGS_JSON" | jq -e '.results' >/dev/null 2>&1; then
+    echo "❌ API Error for ${REPO}:"
+    echo "URL: $TAGS_URL"
+    echo "Response: $TAGS_JSON"
+    continue
+  fi
 
   # 🧠 Filter out sha256-* tags and sort by last_updated (newest first)
   LATEST_TAG=$(echo "$TAGS_JSON" \
     | jq -r '.results 
       | map(select(.name | startswith("sha256-") | not)) 
       | sort_by(.last_updated) 
       | reverse 
-      | .[0].name')
+      | .[0].name' 2>/dev/null || echo "")
 
   if [ "$LATEST_TAG" = "null" ] || [ -z "$LATEST_TAG" ]; then
     echo "⚠️  No valid (non-sha) tags found for ${REPO}, skipping."
@@ -106,10 +133,11 @@ for REPO in "${REPOS[@]}"; do
   echo "📦 Using most recent real tag: ${LATEST_TAG}"
 
   # -------------------------------------------------------------------
-  # 📥 Pull, tag, and push
+  # 📥 Pull, tag, and push (with retries)
   # -------------------------------------------------------------------
+
   echo "📥 Pulling ${SRC_IMAGE}..."
-  if ! docker pull "$SRC_IMAGE"; then
+  if ! retry "docker pull \"$SRC_IMAGE\"" 3 10; then
     echo "❌ Failed to pull ${SRC_IMAGE}, skipping."
     continue
   fi
@@ -121,7 +149,7 @@ for REPO in "${REPOS[@]}"; do
   fi
 
   echo "☁️  Pushing ${DEST_IMAGE}..."
-  if ! docker push "$DEST_IMAGE"; then
+  if ! retry "docker push \"$DEST_IMAGE\"" 3 10; then
     echo "❌ Failed to push ${DEST_IMAGE}, skipping."
     continue
   fi