fix: rickroll selector is broken for captcha test #3207
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jef
reviewed
Jan 31, 2025
Contributor
Author
|
That suggestion unfortunately does let the test pass, but it just sends a small image of a lock. I tried this less precise, but still successful, selector. |
Contributor
Author
|
#3213 was opened for this issue |
jef
approved these changes
Apr 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes the
npm run test:captchatest.The wikipedia has apparently changed the image class, such that img.thumbimage no longer selects anything on the page.
Testing
If you run the test it throws a timeout exception as it is today.
My testing consisted of inspecting the rick roll element, clicking copy selector, and pasting it to replace img.thumbimage, and then running the test.
I'm not a node expert, or a selector expert, so feel free to decline this and change it to something more efficient / less likely to break as this is a very specific selector replacement.
New dependencies
N/A