Skip to content

chore(s3): encode url for returning public url #602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
purerosefallen wants to merge 1 commit into
base: master
Choose a base branch
from
+1 −1
Open

chore(s3): encode url for returning public url #602

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion plugins/assets/s3/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ class S3Assets extends Assets {
}
const { buffer, filename } = await this.analyze(url, file)
const s3Key = `${this.config.pathPrefix}${filename}`
const finalUrl = `${this.config.publicUrl}${filename}`
const finalUrl = `${this.config.publicUrl}${encodeURIComponent(filename)}`
Copy link
Member

@shigma shigma Apr 10, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is slash expected as a suffix for publicUrl?

Copy link
Member Author

@purerosefallen purerosefallen Apr 10, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is designed to match the same behavior as pathPrefix.

try {
const checkExisting = await this.listObjects(s3Key)
if (checkExisting.Contents?.some((obj) => obj.Key === s3Key)) return finalUrl
Expand Down