-
Notifications
You must be signed in to change notification settings - Fork 153
feat: add OCI artifact support for testworkflows #6767
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: add OCI artifact support for testworkflows #6767
Conversation
Signed-off-by: Abhishek Dhiman <[email protected]>
|
hey, @dhimanAbhi thank you for your contribution. Looks like a good work, but there is no api spec changes there, that is sued to generate models |
vsukhin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add api spec changes used for mode generation
Signed-off-by: Abhishek Dhiman <[email protected]>
|
Thanks @vsukhin , I updated api spec and some minor improvements. Let me know if you have any other thoughts or suggestions for further changes! |
|
I have one questions,are CRD installed without kubectl apply --server-side having thier size was increased? |
|
Also, don't you mind to prepare PR for https://github.com/kubeshop/testkube-docs with updated Content spec? |
@vsukhin , I generated CRDs and api spec using Makefile commands |
Definetly. I will soon make a PR for the documentation update. |
It's fine. It's just about testing, because for large CRDs we can have a warning from Kubernetes about thier size |
Sounds Great. Let me know if anything else is required from my end! 🙌 |
Pull request description
This PR introduces support for OCI registry sources in the container executor. It enables fetching test assets directly from OCI-compliant registries (such as Docker Hub, GHCR, or self-hosted registries) as an alternative to Git-based sources. This addition provides a secure and reliable way to distribute test content, especially for air-gapped or restricted network environments, here access to public Git repositories may not be feasible.
It solves issue #4849
Proof Manifests
These are logs of testworkflow execution where I had pushed cypress test defined in testkube/test/cypress/cypress-12 to my dockerhub private repo as an artifact using ORAS. This PR fetches the content just like fetching from Git Source.
Testworkflow Definition
Users can define an OCI registry source specifying:
Template -
Example
Checklist (choose whats happened)
Breaking changes
Changes
Fixes