cluster-provision/gocli Makefile uses hard-coded docker cmd

[orelmisan]

What happened:
When trying to build the gocli image on a system using podman as a container engine, the following command fails:

$ cd cluster-provision/gocli && make container
CGO_ENABLED=0 GOOS=linux GOARCH=$(uname -m | grep -q s390x && echo s390x || echo amd64) go build -ldflags "-X 'kubevirt.io/kubevirtci/cluster-provision/gocli/images.SUFFIX=:'" -o kubevirtci/cluster-provision/gocli/build/cli ./cmd/cli
docker build -t quay.io/kubevirtci/gocli build/
/bin/bash: line 1: docker: command not found
make: *** [Makefile:35: container] Error 127

What you expected to happen:
A clear and concise description of what you expected to happen.

How to reproduce it (as minimally and precisely as possible):
Steps to reproduce the behavior.

Additional context:
Add any other context about the problem here.

Environment:

• KubeVirt version (use virtctl version): N/A
• Kubernetes version (use kubectl version): N/A
• VM or VMI specifications: N/A
• Cloud provider or hardware configuration: N/A
• OS (e.g. from /etc/os-release): Fedora 42
• Kernel (e.g. uname -a): 6.15.3-200
• Install tools: N/A
• Others: N/A

[dosubot]

The Makefile for gocli hardcodes the use of the docker command, so if docker isn't installed (as is common on Fedora, which uses podman), the build will fail with a "command not found" error. There is currently no variable or override mechanism in the Makefile to use podman instead of docker, and no official documentation or workaround for this scenario in kubevirtci yet Makefile source.

Recent pull requests have started adding podman support in other parts of kubevirtci, but this hasn't reached the gocli Makefile yet #1352 #1470.

For now, the most robust workaround is to either install the podman-docker package (which provides a docker-compatible CLI using podman under the hood), or manually edit the Makefile to replace docker with podman for the build and run commands.

To reply, just mention @dosu.

---

^{How did I do? Good | Irrelevant | Incorrect | Verbose | Hallucination | Report 🐛 | Other}   

[brianmcarey]

/label good-first-issue

[kubevirt-bot]

@brianmcarey: Can not set label good-first-issue: Must be member in one of these teams: [restricted-labels-kubevirt]

In response to this:

/label good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[harshitgupta1337]

/assign

[kubevirt-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

[orelmisan]

/remove-lifecycle stale