-
Notifications
You must be signed in to change notification settings - Fork 257
Open
Description
❌ This issue is not open for contribution. Visit Contributing guidelines to learn about the contributing process and how to find suitable issues.
Description
In #5538 and #5563, a license audit task was introduced. However, as per Richard's comment, we will do this computation at publish time instead. This will make the publish workflow take a little bit longer, but it will save us from having to invoke and track a task and download the channel version.
Technical details
- Since we will now handle this new computation more generally, we will have a more general focus for the
community_library_invalid_licensesandcommunity_library_special_permissionsfields, and to prevent scoping these results only for community library processes, we can rename them to benon_distributable_included_licensesandincluded_special_permissions, respectively. - We'll need to remove the task definition and add task tests.
- We'll need to remove the
audit_licensesaction on the Channel Viewset. - We'll need to remove the addition of the
published_datato the Channel Viewset values tuple, and the generation of the change event updating this field. - We'll need to migrate the logic of the
audit_channel_licensesfunction to be called in the publish_channel workflow, and use the Channel snapshot that is already loaded on the publish module, rather than downloading the content database again. - In the frontend, we won't need to invoke the async task, so we'll need to remove the async task loading strings, and we'll need to get the task results directly from the
published_dataobject.
Metadata
Metadata
Assignees
Labels
No labels
