Missing define TLS_ST_OK in LibreSSL header

[brad0]

Building FFmpeg 8.0 or newer now fails as there is a missing define from the state machine which was introduced in OpenSSL 1.1.1.

TLS_ST_OK

Remove redundant code
Redefine old state values
Remove the old state defines

[botovq]

Again this is about
https://github.com/openbsd/ports/blob/bf40f77e48fe5cd2d8dfa22e7eed4b9f54a31964/graphics/ffmpeg/patches/patch-libavformat_tls_openssl_c

[brad0]

I noticed BoringSSL has in their ssl.h header..

// TLS_ST_* are aliases for |SSL_ST_*| for OpenSSL 1.1.0 compatibility.
#define TLS_ST_OK SSL_ST_OK
#define TLS_ST_BEFORE SSL_ST_BEFORE

[botovq]

Thanks. I was thinking about doing something similarly minimal. Good to know they can get away with as little as that. Most of these states are to my knowledge unused. A while back tor used them in a rather nasty info callback hack, but I think they stopped doing that.

[brad0]

Just above what I pasted there is...

// SSL_ST_* are possible values for |SSL_state|, the bitmasks that make them up,
// and some historical values for compatibility. Only |SSL_ST_INIT| and
// |SSL_ST_OK| are ever returned.
#define SSL_ST_CONNECT 0x1000
#define SSL_ST_ACCEPT 0x2000
#define SSL_ST_MASK 0x0FFF
#define SSL_ST_INIT (SSL_ST_CONNECT | SSL_ST_ACCEPT)
#define SSL_ST_OK 0x03
#define SSL_ST_RENEGOTIATE (0x04 | SSL_ST_INIT)
#define SSL_ST_BEFORE (0x05 | SSL_ST_INIT)