Skip to content
This repository was archived by the owner on Jul 24, 2025. It is now read-only.

Conversation

@lucasvallenet
Copy link
Contributor

Remove modularload and use barba instead.
It is located in the same module Load.js and uses the data-module-load namespace.

I also added a config.js file in the script root to have global vars (env, classnames, etc...) and updated the utils/environment.js with dom elements.

@mcaskill mcaskill changed the title Add Barba Replace ModularLoad with Barba May 20, 2022
@lucasvallenet
Copy link
Contributor Author

lucasvallenet commented May 25, 2022

We won't merge the barba branch yet, but I think we could make use of the config.js already. Any idea on how to implement that, should I create a new pull request with this file only ?

@mcaskill
Copy link
Member

We won't merge the barba branch yet, but I think we could make use of the config.js already. Any idea on how to implement that, should I create a new pull request with this file only ?

Yes, create a new pull request with only the changes to config.js (dom.js and environment.js, too?). Then this pull request can be rebased according to that and merged afterwards when ready.

@lucasvallenet
Copy link
Contributor Author

We can maybe add these changed to PR#120 that is likely to be merged soon ?

@lucasvallenet lucasvallenet requested a review from arnvvd May 30, 2022 14:21
@arnvvd
Copy link
Contributor

arnvvd commented Oct 5, 2022

Outcome from meeting on 2022-10-05
Status: On hold until further notice.
We like the idea, but we need to do more tests before deciding if we use Barba.js. It depends on our current usage of modular load.

@arnvvd arnvvd added the on hold label Oct 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants