-
Notifications
You must be signed in to change notification settings - Fork 69
Add default wysiwyg file #174
base: master
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
mcaskill
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awfully convoluted.
Why are there so many margin declarations, repetitions, and adjustments?
Are there no other elements combinations beyond p, ol, ul, table, and figure?
Isn't .c-wysiwyg > * + * good enough, maybe with h1 + *?
What's with the random sprinkling of paddings and pixels?
The latter (pixels) should at least be informed by the related font size.
It would be nice if ol and ul just used the default browser styles instead of relying on pseudo-elements.
Remove empty style for thead and tr
|
Thanks @mcaskill for the complete review. I realized it was way too soon to set this PR 'Ready for review'. |
| & > * + * { | ||
| margin-bottom: size-clamp('md'); | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| & > * + * { | |
| margin-bottom: size-clamp('md'); | |
| } | |
| & > * + * { | |
| margin-top: size-clamp('md'); | |
| } |
Wysiwyg sass file including all default style.
Could be overwritten if needed depending on the project needs.
Headings mixins are commented for now since they're not implemented by default (yet).