fix(sdk): Better handling of redacted and redaction events in Latest Event #5932
+184
−66
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch revisits the way redacted and redaction events are handled in the Latest Event.
Previously, all redacted events were considered suitable candidate. It's no longer the case.
Only redaction event (
m.room.redaction) are considered suitable candidate if and only if it targets the immediate previous event, and if and only if the previous event is itself a suitable candidate.To achieve so, the
rfind_map_event_in_memory_bymethod is revisited to return the&TimelineEventinstead of theOwnedEventId.The tests have been updated accordingly.