-
Notifications
You must be signed in to change notification settings - Fork 0
[#900] Configuration openklant #917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
af91ab4 to
4d5ebe8
Compare
4d5ebe8 to
c8ab406
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #917 +/- ##
==========================================
+ Coverage 90.28% 90.39% +0.10%
==========================================
Files 214 227 +13
Lines 6885 7119 +234
Branches 696 704 +8
==========================================
+ Hits 6216 6435 +219
- Misses 669 684 +15
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
c8ab406 to
b7578af
Compare
| from solo.models import SingletonModel | ||
|
|
||
|
|
||
| class OpenKlantConfig(SingletonModel): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While working on #901 I am considering changing this to a non-solo model.
Then each plugin would be related to a specific instance of a PluginConfig model with a specific identifier (a bit like we have for the mozilla-django-oidc-db package).
This has the advantage that if we want to go from the Service to the plugin, we can do :
config = Service.pluginconfig_set.first()
plugin = register[config._plugin_identifier]instead of having to figure out which many-to-many accessors there are on the Service that correspond to plugin configuration models and then which of these querysets is non empty 🤔
1fa2525 to
36702c6
Compare
Fixes #900
Depends on #921