Skip to content

Conversation

@SilviaAmAm
Copy link
Collaborator

@SilviaAmAm SilviaAmAm commented Nov 25, 2025

Fixes #900

Depends on #921

@SilviaAmAm SilviaAmAm marked this pull request as draft November 25, 2025 16:58
@SilviaAmAm SilviaAmAm force-pushed the feature/900-configuration-openklant branch 2 times, most recently from af91ab4 to 4d5ebe8 Compare November 28, 2025 09:53
@SilviaAmAm SilviaAmAm force-pushed the feature/900-configuration-openklant branch from 4d5ebe8 to c8ab406 Compare November 28, 2025 15:01
@codecov-commenter
Copy link

codecov-commenter commented Nov 28, 2025

Codecov Report

❌ Patch coverage is 95.95960% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.39%. Comparing base (380ffdd) to head (7bfa389).
⚠️ Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
...src/openarchiefbeheer/external_registers/plugin.py 89.13% 5 Missing ⚠️
...eer/external_registers/contrib/openklant/plugin.py 88.88% 3 Missing ⚠️
...c/openarchiefbeheer/external_registers/registry.py 91.30% 2 Missing ⚠️
...ers/contrib/openklant/setup_configuration/steps.py 94.73% 1 Missing ⚠️
...ngs/pages/health-check/HealthCheckSettingsPage.tsx 90.90% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #917      +/-   ##
==========================================
+ Coverage   90.28%   90.39%   +0.10%     
==========================================
  Files         214      227      +13     
  Lines        6885     7119     +234     
  Branches      696      704       +8     
==========================================
+ Hits         6216     6435     +219     
- Misses        669      684      +15     
Flag Coverage Δ
backend 91.62% <96.07%> (+0.16%) ⬆️
jest 34.11% <11.76%> (-0.19%) ⬇️
storybook 83.48% <94.11%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@SilviaAmAm SilviaAmAm force-pushed the feature/900-configuration-openklant branch from c8ab406 to b7578af Compare December 1, 2025 14:15
@svenvandescheur svenvandescheur self-requested a review December 2, 2025 10:27
@SilviaAmAm SilviaAmAm marked this pull request as ready for review December 2, 2025 11:29
@SilviaAmAm SilviaAmAm requested a review from CharString December 2, 2025 11:35
from solo.models import SingletonModel


class OpenKlantConfig(SingletonModel):
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While working on #901 I am considering changing this to a non-solo model.

Then each plugin would be related to a specific instance of a PluginConfig model with a specific identifier (a bit like we have for the mozilla-django-oidc-db package).

This has the advantage that if we want to go from the Service to the plugin, we can do :

config = Service.pluginconfig_set.first()
plugin = register[config._plugin_identifier]

instead of having to figure out which many-to-many accessors there are on the Service that correspond to plugin configuration models and then which of these querysets is non empty 🤔

@SilviaAmAm SilviaAmAm force-pushed the feature/900-configuration-openklant branch from 1fa2525 to 36702c6 Compare December 5, 2025 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

As a developer I need a configuration object to determine what Service should be used for what plugin / registry.

4 participants