Skip to content

Conversation

@HO-COOH
Copy link
Contributor

@HO-COOH HO-COOH commented Jun 10, 2024

Summary of the Pull Request

This idea comes from @Shomnipotence. It replaces the old tray icon with a new outlined design and adapts to windows' theme changes.

PR Checklist

  • Closes: #xxx
  • Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
  • Tests: Added/updated and all pass
  • Localization: All end user facing strings can be localized
  • Dev docs: Added/updated
  • New binaries: Added on the required places
  • Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

This should be obvious enough with the video

2024-06-11.00-02-32.mp4

Validation Steps Performed

  1. Start powertoys, it loads the tray icon of the current theme.
  2. Switch theme in windows settings, it dynamically adapts.

@github-actions

This comment has been minimized.

@Shomnipotence
Copy link

image
This line drawing style icon will make it consistent with the native UI of the operating system.

@htcfreek
Copy link
Collaborator

@HO-COOH

  1. Is there an existing issue? If not please create one for discussion and tracking.
  2. Was this ever discussed with the core team?

@HO-COOH
Copy link
Contributor Author

HO-COOH commented Jun 11, 2024

@HO-COOH

  1. Is there an existing issue? If not please create one for discussion and tracking.
  2. Was this ever discussed with the core team?

I am just here helping out @Shomnipotence to implement what he wanted. For existing issue, see the two referenced by him.

@ayZagen
Copy link

ayZagen commented Sep 15, 2024

It looks great, I hope it got merged soon

@yeelam-gordon yeelam-gordon added the Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams label Apr 8, 2025
@akamienski
Copy link

That looks great, now please also do that for Awake tray icon too.

@zadjii-msft zadjii-msft added the Needs-Discussion The team needs to talk about this label Aug 22, 2025
@yeelam-gordon
Copy link
Contributor

@niels9001, need your input on this PR. Not sure we already consider our new icon for the dark theme work.

@niels9001
Copy link
Collaborator

@HO-COOH Thanks for raising this PR and apologies for letting it get stale.

I'm fine with these changes - but I think this should be a setting as some people do prefer a colored version. We'd also need to update the outline version of the icon so ensure it matches the PowerToys icon.

Just wanted to check if you're still on point for this PR?

@niels9001 niels9001 added Product-Settings The standalone PowerToys Settings application Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something and removed Needs-Discussion The team needs to talk about this Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams labels Nov 3, 2025
@HO-COOH
Copy link
Contributor Author

HO-COOH commented Nov 3, 2025

@HO-COOH Thanks for raising this PR and apologies for letting it get stale.

I'm fine with these changes - but I think this should be a setting as some people do prefer a colored version. We'd also need to update the outline version of the icon so ensure it matches the PowerToys icon.

Just wanted to check if you're still on point for this PR?

I can add a setting for this feature. As for design wise, please shout out to @Shomnipotence

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams Needs-Team-Response An issue author responded so the team needs to follow up and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Nov 3, 2025
@Shomnipotence
Copy link

Shomnipotence commented Nov 3, 2025

@HO-COOH Thanks for raising this PR and apologies for letting it get stale.

I'm fine with these changes - but I think this should be a setting as some people do prefer a colored version. We'd also need to update the outline version of the icon so ensure it matches the PowerToys icon.

Just wanted to check if you're still on point for this PR?

I noticed that the colored version of the PowerToys icon hasn't been updated. Was it updated in the preview version?
I guarantee the current version matches the current colored icon.
image

@niels9001
Copy link
Collaborator

niels9001 commented Dec 5, 2025

Thanks for the updates. Let's get this in!

@HO-COOH would you mind adding this as a setting on the General page with the colored icon as the default option?

IMAGE_ICON,
0,
0,
LR_LOADFROMFILE | LR_DEFAULTSIZE | LR_SHARED));

Check failure

Code scanning / check-spelling

Unrecognized Spelling Error

DEFAULTSIZE is not a recognized word. (unrecognized-spelling)
@github-actions
Copy link

github-actions bot commented Dec 5, 2025

@check-spelling-bot Report

🔴 Please review

See the 📂 files view, the 📜action log, or 📝 job summary for details.

Unrecognized words (1)

DEFAULTSIZE

These words are not needed and should be removed CLITo CVS Notavailable

To accept these unrecognized words as correct and remove the previously acknowledged and now absent words, you could run the following commands

... in a clone of the [email protected]:HO-COOH/PowerToys.git repository
on the feat/tray-icon branch (ℹ️ how do I use this?):

curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/c635c2f3f714eec2fcf27b643a1919b9a811ef2e/apply.pl' |
perl - 'https://github.com/microsoft/PowerToys/actions/runs/19969965615/attempts/1' &&
git commit -m 'Update check-spelling metadata'
If the flagged items are 🤯 false positives

If items relate to a ...

  • binary file (or some other file you wouldn't want to check at all).

    Please add a file path to the excludes.txt file matching the containing file.

    File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

    ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

  • well-formed pattern.

    If you can write a pattern that would match it,
    try adding it to the patterns.txt file.

    Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

    Note that patterns can't match multiline strings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs-Team-Response An issue author responded so the team needs to follow up Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams Product-Settings The standalone PowerToys Settings application

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants