-
Notifications
You must be signed in to change notification settings - Fork 7.5k
Feat: New tray-icon that adapts to theme change #33321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This comment has been minimized.
This comment has been minimized.
|
I am just here helping out @Shomnipotence to implement what he wanted. For existing issue, see the two referenced by him. |
|
It looks great, I hope it got merged soon |
|
That looks great, now please also do that for Awake tray icon too. |
|
@niels9001, need your input on this PR. Not sure we already consider our new icon for the dark theme work. |
|
@HO-COOH Thanks for raising this PR and apologies for letting it get stale. I'm fine with these changes - but I think this should be a setting as some people do prefer a colored version. We'd also need to update the outline version of the icon so ensure it matches the PowerToys icon. Just wanted to check if you're still on point for this PR? |
I can add a setting for this feature. As for design wise, please shout out to @Shomnipotence |
I noticed that the colored version of the PowerToys icon hasn't been updated. Was it updated in the preview version? |
|
Thanks for the updates. Let's get this in! @HO-COOH would you mind adding this as a setting on the General page with the colored icon as the default option? |
| IMAGE_ICON, | ||
| 0, | ||
| 0, | ||
| LR_LOADFROMFILE | LR_DEFAULTSIZE | LR_SHARED)); |
Check failure
Code scanning / check-spelling
Unrecognized Spelling Error
@check-spelling-bot Report🔴 Please reviewSee the 📂 files view, the 📜action log, or 📝 job summary for details.Unrecognized words (1)DEFAULTSIZE These words are not needed and should be removedCLITo CVS NotavailableTo accept these unrecognized words as correct and remove the previously acknowledged and now absent words, you could run the following commands... in a clone of the [email protected]:HO-COOH/PowerToys.git repository curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/c635c2f3f714eec2fcf27b643a1919b9a811ef2e/apply.pl' |
perl - 'https://github.com/microsoft/PowerToys/actions/runs/19969965615/attempts/1' &&
git commit -m 'Update check-spelling metadata'If the flagged items are 🤯 false positivesIf items relate to a ...
|


Summary of the Pull Request
This idea comes from @Shomnipotence. It replaces the old tray icon with a new outlined design and adapts to windows' theme changes.
PR Checklist
Detailed Description of the Pull Request / Additional comments
This should be obvious enough with the video
2024-06-11.00-02-32.mp4
Validation Steps Performed