nes: model picker: fix: correct init and model picking order #2437
+19
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* nes: fetched models should check if they're already known as well * nes: fix: ensure to update undesired models before updating preferred model this's important because there's code that reacts to preferred model change and needs to know latest undesired models * nes: minimize failure possibility * nes: fix: make sure to init undesiredModelsManager earlier than observables use them * nes: don't memorize if exp-configured model is picked
ulugbekna
added
the
candidate
ulugbekna
changed the title
benibenj
approved these changes
Dec 5, 2025
ulugbekna
deleted the
ulugbekna/nes-candidate-fix-model-picker-breakage
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes microsoft/vscode#281494
nes: fetched models should check if they're already known as well
nes: fix: ensure to update undesired models before updating preferred model
this's important because there's code that reacts to preferred model change and needs to know latest undesired models
nes: minimize failure possibility
nes: fix: make sure to init undesiredModelsManager earlier than observables use them
nes: don't memorize if exp-configured model is picked