Skip to content

Commit adc95d1

Browse files
committed
Fixed bugs
1 parent dfd62c6 commit adc95d1

File tree

4 files changed

+19
-12
lines changed

4 files changed

+19
-12
lines changed

.idea/misc.xml

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

app/src/main/java/nie/translator/rtranslator/voice_translation/_text_translation/TranslationFragment.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -254,8 +254,8 @@ public void onClick(View view) {
254254
}*/
255255

256256
if(!text.isEmpty()) {
257-
CustomLocale firstLanguage = global.getFirstLanguage(true);
258-
CustomLocale secondLanguage = global.getSecondLanguage(true);
257+
CustomLocale firstLanguage = global.getFirstTextLanguage(true);
258+
CustomLocale secondLanguage = global.getSecondTextLanguage(true);
259259
//we deactivate translate button
260260
deactivateTranslationButton();
261261
//we start the translation
@@ -457,8 +457,8 @@ public void onClick(View v) {
457457
invertLanguagesButton.setOnClickListener(new View.OnClickListener() {
458458
@Override
459459
public void onClick(View v) {
460-
CustomLocale firstLanguage = global.getFirstLanguage(true);
461-
CustomLocale secondLanguage = global.getSecondLanguage(true);
460+
CustomLocale firstLanguage = global.getFirstTextLanguage(true);
461+
CustomLocale secondLanguage = global.getSecondTextLanguage(true);
462462
animator.animateSwitchLanguages(activity, firstLanguageSelector, secondLanguageSelector, invertLanguagesButton, new CustomAnimator.Listener() {
463463
@Override
464464
public void onAnimationEnd() {

app/src/main/java/nie/translator/rtranslator/voice_translation/neural_networks/translation/BergamotTranslator.java

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
import android.os.Environment;
55

66
import java.io.File;
7+
import java.util.Objects;
78

89
import javax.annotation.Nullable;
910

@@ -27,9 +28,11 @@ public static void initializeService(){
2728

2829
public static void loadModelIntoCache(Context context, CustomLocale lang) throws Exception{
2930
String langCode = lang.getLanguage();
30-
String toEngCfg = modelConfigGeneration(context, langCode, ModelType.TO_ENGLISH);
31-
String fromEngCfg = modelConfigGeneration(context, langCode, ModelType.FROM_ENGLISH);
32-
loadModelIntoCacheNative(toEngCfg, fromEngCfg, langCode);
31+
if(!Objects.equals(langCode, "en")) {
32+
String toEngCfg = modelConfigGeneration(context, langCode, ModelType.TO_ENGLISH);
33+
String fromEngCfg = modelConfigGeneration(context, langCode, ModelType.FROM_ENGLISH);
34+
loadModelIntoCacheNative(toEngCfg, fromEngCfg, langCode);
35+
}
3336
}
3437

3538
public static void unloadModelFromCache(CustomLocale lang){

app/src/main/java/nie/translator/rtranslator/voice_translation/neural_networks/translation/Translator.java

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,8 @@ public class Translator extends NeuralNetworkApi {
110110
"fr",
111111
"de",
112112
"ko",
113-
"ja"
113+
"ja",
114+
"en"
114115
};
115116

116117

@@ -491,12 +492,15 @@ public void loadMozillaModels(CustomLocale srcLang, CustomLocale trgLang, Global
491492
}
492493
//we load in bergamot translator the new models that are not already loaded
493494
ArrayList<CustomLocale> allUniqueModels = bergamotModelsIndicator.getAllUniqueModels();
494-
if (!allUniqueModels.contains(srcLang)) {
495+
if (!allUniqueModels.contains(srcLang) && !srcLang.getLanguage().equals("en")) {
495496
BergamotTranslator.loadModelIntoCache(global, srcLang);
496497
}
498+
if (!allUniqueModels.contains(trgLang) && !trgLang.getLanguage().equals("en")) {
499+
BergamotTranslator.loadModelIntoCache(global, trgLang);
500+
}
497501
//we update the indicator to reflect the new models status
498-
currentModeModels[0] = srcLang;
499-
currentModeModels[1] = trgLang;
502+
currentModeModels[0] = !srcLang.getLanguage().equals("en") ? srcLang : null;
503+
currentModeModels[1] = !trgLang.getLanguage().equals("en") ? trgLang : null;
500504
//we notify the success of the loading
501505
listener.onSuccess();
502506
} catch (Exception e) {

0 commit comments

Comments
 (0)