Format "date" with "required" generates invalid mock with msw

[trumppk]

When generating a type

    MyType:
      type: object
      required:
        - id
        - myDate
      properties:
        id:
          type: string
        myDate
          type: string
          format: date

Then the generated msw code contains an mock with invalid type:

              Types of property 'myDate' are incompatible.
                Type 'string | undefined' is not assignable to type 'string'.
                  Type 'undefined' is not assignable to type 'string'.

[melloware]

investigation or PR is welcome!

[Armanio]

@trumppk
Hi!
Do you have repro or more information?
I tried generate mock with that sample and get correct mocks:

export type MyType = {
  id: string;
  myDate: string;
};

export const getGetOrderCharacteristicsResponseMock = (
  overrideResponse: Partial<OrderCharacteristicsResponse> = {},
): OrderCharacteristicsResponse => ({
  order: {
    characteristics: {
      id: faker.string.alpha({ length: { min: 10, max: 20 } }),
      myDate: faker.date.past().toISOString().split('T')[0],
    },
  },
  ...overrideResponse,
});

[trumppk]

But should the type not be
myDate: faker.date.past().toISOString().split('T')[0]!,
(mark the '!'),
so that the type does not include undefined?

[Armanio]

Sorry, not understood, why? .split return string[] type, we can use indexed signature to get any part

[trumppk]

Yes, but accessing an array through an index can always return undefined as TS is not able to tell which size the array would have during runtime, but undefined is not allowed as type.
I'm using tsc version 5.9.3.

[Armanio]

Sorry againt but I can't reproduce reproduce this behavior: tsplay
Maybe problem in your tsconfig?

[lucas-guillemin]

@trumppk Had the same issue and solved it using format in configuration: https://orval.dev/reference/configuration/output#format

output: {
	override: {
		mock: {
		    format: {
		        date: 'faker.date.past().toISOString().split("T")[0]!',
		      }
		}
	}
}

Hope this helps !