-
-
Notifications
You must be signed in to change notification settings - Fork 13
Description
I’m not sure if it is already handled here, but there are some restrictions and rate limits when using pull request review comments on GitHub. The tool that I use in another project (reviewdog) for example, handles it like this comment: OSGeo/grass-addons#1458 (review)
There is a text explaining that the following ranges of lines (with links) had comments that couldn’t be posted to avoid these rate limits. It occasionally happens when a bigger PR with many new files who weren’t formatted at all is submitted, and lots and lots of review comments would’ve been posted.
I don’t know exactly what these rate limits are. Are they related to the number of review comments in a single API call? Are they related to the time in between API calls (if more than one call is used)? Is it related to the size in characters or bytes of each of the comments + the summary comment (I expect it should be limited to something near the limits of a MySQL TEXT column like other posts on GitHub)? Or maybe the total size of the payload is limited?
Since reviewdog handles more than pull request review comments, (comments, annotations, status checks, etc.) and more than GitHub, reading their old 3-year old PR extending these checks didn’t help me understand what were the limits at the time.
These are some suggestions to explore to help this project. I see you have been exploring the use of delegating to copilot, it was my first time seeing this a couple weeks ago, so I don’t feel that bad to write up some potential improvements as issues here, even if I don’t immediately need it. Even if it only serves as creating some better test cases. I specifically didn’t link to the other tool I’m comparing to, to not bias too much an LLM.
Keep up the good work!