apply naming convention 'try_' prefix for fallible setters/constructors

most were already up to par with the new standard,
but a quick scan revelead some more that still weren't up to this standard.

Noticed while updating a fleet of services with the pool methods
of the web client easy API not prefixed with `try_` yet

Author: GlenDC

examples/acme_http_challenge.rs

@@ -127,7 +127,7 @@ async fn main() {
         .build_client()
         .boxed();
 
-    let client = AcmeClient::new(TEST_DIRECTORY_URL, client)
+    let client = AcmeClient::try_new(TEST_DIRECTORY_URL, client)
         .await
         .expect("create acme client");
 
@@ -154,7 +154,7 @@ async fn main() {
         .expect("create account");
 
     let mut order = account
-        .new_order(NewOrderPayload {
+        .try_new_order(NewOrderPayload {
             identifiers: vec![Identifier::dns("example.com")],
             ..Default::default()
         })

examples/acme_tls_challenge_using_boring.rs

@@ -126,7 +126,7 @@ async fn main() {
         .build_client()
         .boxed();
 
-    let client = AcmeClient::new(TEST_DIRECTORY_URL, client)
+    let client = AcmeClient::try_new(TEST_DIRECTORY_URL, client)
         .await
         .expect("create acme client");
 
@@ -145,7 +145,7 @@ async fn main() {
         .expect("create account");
 
     let mut order = account
-        .new_order(NewOrderPayload {
+        .try_new_order(NewOrderPayload {
             identifiers: vec![Identifier::dns("example.com")],
             ..Default::default()
         })

examples/acme_tls_challenge_using_rustls.rs

@@ -123,7 +123,7 @@ async fn main() {
         .build_client()
         .boxed();
 
-    let client = AcmeClient::new(TEST_DIRECTORY_URL, client)
+    let client = AcmeClient::try_new(TEST_DIRECTORY_URL, client)
         .await
         .expect("create acme client");
 
@@ -140,7 +140,7 @@ async fn main() {
         .expect("create account");
 
     let mut order = account
-        .new_order(NewOrderPayload {
+        .try_new_order(NewOrderPayload {
             identifiers: vec![Identifier::dns("example.com")],
             ..Default::default()
         })

examples/http_mitm_proxy_boring.rs

@@ -141,7 +141,7 @@ async fn main() -> Result<(), BoxError> {
         .init();
 
     let mitm_tls_service_data =
-        new_mitm_tls_service_data().context("generate self-signed mitm tls cert")?;
+        try_new_mitm_tls_service_data().context("generate self-signed mitm tls cert")?;
 
     let state = State {
         mitm_tls_service_data,
@@ -341,7 +341,7 @@ async fn http_mitm_proxy(req: Request) -> Result<Response, Infallible> {
 // NOTE: for a production service you ideally use
 // an issued TLS cert (if possible via ACME). Or at the very least
 // load it in from memory/file, so that your clients can install the certificate for trust.
-fn new_mitm_tls_service_data() -> Result<TlsAcceptorData, OpaqueError> {
+fn try_new_mitm_tls_service_data() -> Result<TlsAcceptorData, OpaqueError> {
     let tls_server_config = ServerConfig {
         application_layer_protocol_negotiation: Some(vec![
             ApplicationProtocol::HTTP_2,

examples/http_mitm_proxy_rustls.rs

@@ -90,7 +90,7 @@ async fn main() -> Result<(), BoxError> {
         .init();
 
     let mitm_tls_service_data =
-        new_mitm_tls_service_data().context("generate self-signed mitm tls cert")?;
+        try_new_mitm_tls_service_data().context("generate self-signed mitm tls cert")?;
 
     let state = State {
         mitm_tls_service_data,
@@ -248,8 +248,8 @@ async fn http_mitm_proxy(req: Request) -> Result<Response, Infallible> {
 // NOTE: for a production service you ideally use
 // an issued TLS cert (if possible via ACME). Or at the very least
 // load it in from memory/file, so that your clients can install the certificate for trust.
-fn new_mitm_tls_service_data() -> Result<TlsAcceptorData, OpaqueError> {
-    let data = TlsAcceptorDataBuilder::new_self_signed(SelfSignedData {
+fn try_new_mitm_tls_service_data() -> Result<TlsAcceptorData, OpaqueError> {
+    let data = TlsAcceptorDataBuilder::try_new_self_signed(SelfSignedData {
         organisation_name: Some("Example Server Acceptor".to_owned()),
         ..Default::default()
     })

examples/http_pooled_client.rs

@@ -58,7 +58,7 @@ async fn main() {
         .with_proxy_support()
         .without_tls_support()
         .with_default_http_connector()
-        .with_connection_pool(Default::default())
+        .try_with_connection_pool(Default::default())
         .expect("connection pool")
         .build_client();
 

examples/http_record_har.rs

@@ -118,7 +118,7 @@ async fn main() -> Result<(), BoxError> {
         .init();
 
     let mitm_tls_service_data =
-        new_mitm_tls_service_data().context("generate self-signed mitm tls cert")?;
+        try_new_mitm_tls_service_data().context("generate self-signed mitm tls cert")?;
 
     let graceful = rama::graceful::Shutdown::default();
 
@@ -340,7 +340,7 @@ async fn http_mitm_proxy(req: Request) -> Result<Response, Infallible> {
 // NOTE: for a production service you ideally use
 // an issued TLS cert (if possible via ACME). Or at the very least
 // load it in from memory/file, so that your clients can install the certificate for trust.
-fn new_mitm_tls_service_data() -> Result<TlsAcceptorData, OpaqueError> {
+fn try_new_mitm_tls_service_data() -> Result<TlsAcceptorData, OpaqueError> {
     let tls_server_config = ServerConfig {
         application_layer_protocol_negotiation: Some(vec![
             ApplicationProtocol::HTTP_2,

examples/https_connect_proxy.rs

@@ -100,7 +100,7 @@ async fn main() {
 
     #[cfg(all(feature = "rustls", not(feature = "boring")))]
     let tls_service_data = {
-        TlsAcceptorDataBuilder::new_self_signed(SelfSignedData {
+        TlsAcceptorDataBuilder::try_new_self_signed(SelfSignedData {
             organisation_name: Some("Example Server Acceptor".to_owned()),
             ..Default::default()
         })

examples/https_web_service_with_hsts.rs

@@ -91,7 +91,7 @@ async fn main() {
 
     #[cfg(all(feature = "rustls", not(feature = "boring")))]
     let tls_service_data = {
-        TlsAcceptorDataBuilder::new_self_signed(SelfSignedData {
+        TlsAcceptorDataBuilder::try_new_self_signed(SelfSignedData {
             organisation_name: Some("Example Server Acceptor".to_owned()),
             ..Default::default()
         })

examples/socks5_connect_proxy_mitm_proxy.rs

@@ -76,7 +76,7 @@ async fn main() {
         .init();
 
     let mitm_tls_service_data =
-        new_mitm_tls_service_data().expect("generate self-signed mitm tls cert");
+        try_new_mitm_tls_service_data().expect("generate self-signed mitm tls cert");
 
     let graceful = rama::graceful::Shutdown::default();
 
@@ -179,7 +179,7 @@ async fn http_mitm_proxy(req: Request) -> Result<Response, Infallible> {
 // NOTE: for a production service you ideally use
 // an issued TLS cert (if possible via ACME). Or at the very least
 // load it in from memory/file, so that your clients can install the certificate for trust.
-fn new_mitm_tls_service_data() -> Result<TlsAcceptorData, OpaqueError> {
+fn try_new_mitm_tls_service_data() -> Result<TlsAcceptorData, OpaqueError> {
     let tls_server_config = ServerConfig {
         application_layer_protocol_negotiation: Some(vec![
             ApplicationProtocol::HTTP_2,