Skip to content

Commit e9e35e9

Browse files
committed
Improve testing directions in the readme
1 parent 96de0b1 commit e9e35e9

File tree

2 files changed

+8
-11
lines changed

2 files changed

+8
-11
lines changed

.github/workflows/ci.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ jobs:
1313
matrix:
1414
os: [ ubuntu-20.04 ]
1515
rack: [ '~> 2.0', '~> 3.0' ]
16-
ruby: [ 2.3, 2.4, 2.5, 2.6, 2.7, '3.0', 3.1, 3.2 ]
16+
ruby: [ 2.3, 2.4, 2.5, 2.6, 2.7, '3.0', 3.1, 3.2, 3.3 ]
1717
gemfile: [ Gemfile ]
1818
exclude:
1919
# Rack 3 needs >= Ruby 2.4

README.md

Lines changed: 7 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ This package is [semver compliant](https://semver.org); you should use a
6565
pessimistic version constraint (`~>`) against the relevant `2.x` version of
6666
this gem.
6767

68-
This version of `rack-contrib` is only compatible with `rack` 2.x. If you
68+
This version of `rack-contrib` is compatible with `rack` 2.x and 3.x. If you
6969
are using `rack` 1.x, you will need to use `rack-contrib` 1.x. A suitable
7070
pessimistic version constraint (`~>`) is recommended.
7171

@@ -74,19 +74,16 @@ pessimistic version constraint (`~>`) is recommended.
7474

7575
To contribute to the project, begin by cloning the repo and installing the necessary gems:
7676

77-
gem install json rack ruby-prof test-spec test-unit
77+
gem install bundler
78+
bundle install
7879

79-
To run the entire test suite, run
80+
To run the entire test suite, run:
8081

81-
rake test
82+
bundle exec rake test
8283

83-
To run a specific component's tests run
84+
To run a specific component's tests, use the `TEST` environment variable:
8485

85-
specrb -Ilib:test -w test/spec_rack_thecomponent.rb
86-
87-
This works on ruby 1.8.7 but has problems under ruby 1.9.x.
88-
89-
TODO: instructions for 1.9.x and include bundler
86+
TEST=test/spec_rack_thecomponent.rb bundle exec rake test
9087

9188
### Criteria for inclusion
9289
The criteria for middleware being included in this project are roughly as follows:

0 commit comments

Comments
 (0)